- Notifications
You must be signed in to change notification settings - Fork44
Jsx adaptions#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -0,0 +1,30 @@ | |||
| @@warning("-27") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Where is this coming from? I don't think the ppx adds -27 so I'm surprised to see it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I added the -27 attribute manually though
| "createElement" | ||
| @module("react") @deprecated("Please use JSX syntax directly.") | ||
| @module("react/jsx-runtime") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we still want the@deprecated here. We want people to use JSX syntax or createElement. If we need to create a directly usable api we can do that outside of this work.
cknitt commentedSep 25, 2022
@ryyppy I guess this is obsolete and can be closed? |
cknitt commentedSep 28, 2022
@ryyppy @mattdamon108 Is there anything still relevant in this PR or can it be closed? |
mununki commentedSep 28, 2022
I think JSX v4 has already a transformation using |
cknitt commentedSep 29, 2022
Ok, so I am closing this one now. |
No description provided.