- Notifications
You must be signed in to change notification settings - Fork471
compiler: update typecore; tests: add VariantCoercionConstructUsed; d…#7839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cristianoc wants to merge8 commits intomasterChoose a base branch fromcodex-on-issue-7838
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
992088e compiler: update typecore; tests: add VariantCoercionConstructUsed; d…
cristianoc7f1f3c4 next iter
cristianoc1844a6c typecore: mark constructors used on variant coercion; add super-error…
cristianoc6012c86 changelog: link variant coercion unused-constructor fix to #7839
cristianoc5d5e111 typecore: avoid option tuple match; wrap both extractions in single t…
cristianocbfcef55 typecore: speed up constructor membership with StringSet
cristianoc2c6a0e9 chore: remove example.res and issue.txt
cristianoc7da7c05 typecore: avoid false 'constructor … is never used' after variant coe…
cristianocFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
PrevPrevious commit
typecore: avoid false 'constructor … is never used' after variant coe…
…rcionMark shared constructors as used on the target variant after successful coercion; keep warnings for target-only constructors. Part of#7839.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit7da7c056cc92ecfa2b11e189283a7720d56a6ef7
There are no files selected for viewing
20 changes: 2 additions & 18 deletionscompiler/ml/typecore.ml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.