- Notifications
You must be signed in to change notification settings - Fork471
[PoC] support inline/nested records inside of externals#7791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cc@nojaf |
rescript@rescript/darwin-arm64@rescript/darwin-x64@rescript/linux-arm64@rescript/linux-x64@rescript/win32-x64commit: |
This would make writing bindings so much easier!! |
| @@ -0,0 +1,9 @@ | |||
| @module("node:fs") | |||
| external readFileSync: (string, ~options: { | |||
| encoding?: [#utf8 | #ascii | #base64], | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would regular variants also work here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not inline, no. But you could reference a defined one.
Beautiful! Ship it! |
Closes#7386
Mostly a PoC for now, to see if it was possible to just extend the current mechanisms to this. Feedback appreciated. There are still issues to solve, but this serves as a base for discussion/experimentation.
Support inline record definitions in externals: