Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Move changelog empty check after categorization for accuracy#1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Bledai wants to merge1 commit intorelease-drafter:master
base:master
Choose a base branch
Loading
fromBledai:patch-1

Conversation

@Bledai
Copy link

@BledaiBledai commentedFeb 6, 2025•
edited
Loading

Previously, the changelog check was based onmergedPullRequests.length, which could be misleading since some PRs might be filtered out or uncategorized. This change ensures the check happens after categorization, making sure only meaningful PRs are considered.

  • Moved the "no changes" check after PR categorization
  • Improved accuracy by counting only categorized and uncategorized PRs
  • Optimized changelog generation by preventing unnecessary processing

Fixes potential issues where a release might be marked as having changes when none remain after filtering.

---------------------------|---------|----------|---------|---------|--------------------------File                       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s        ---------------------------|---------|----------|---------|---------|--------------------------All files                  |   85.79 |    78.57 |   89.13 |   85.98 |                           release-drafter           |   55.83 |    56.48 |      50 |   54.62 |                            index.js                 |   55.83 |    56.48 |      50 |   54.62 | 18-19,35-128,231,265,273  release-drafter/lib       |   94.03 |    89.71 |    93.9 |   94.04 |                            commits.js               |   97.56 |    85.71 |     100 |    97.5 | 145                        config.js                |   96.15 |    85.71 |     100 |   96.15 | 41                         default-config.js        |     100 |      100 |     100 |     100 |                            log.js                   |     100 |       75 |     100 |     100 | 3                          pagination.js            |   95.23 |    85.71 |     100 |   94.73 | 31                         releases.js              |   96.51 |       90 |    97.5 |   96.39 | 20,45,59,117,517,520,526   schema.js                |   91.66 |      100 |     100 |    91.3 | 207,216                    sort-pull-requests.js    |   86.36 |       75 |     100 |   88.88 | 35,41                      template.js              |      75 |      100 |   66.66 |      75 | 42-46,55-73                triggerable-reference.js |     100 |      100 |     100 |     100 |                            utils.js                 |     100 |      100 |     100 |     100 |                            versions.js              |   94.59 |    94.28 |     100 |   94.59 | 193,205                  ---------------------------|---------|----------|---------|---------|--------------------------Test Suites: 7 passed, 7 totalTests:       156 passed, 156 totalSnapshots:   65 passed, 65 totalTime:        2.377 s, estimated 3 sRan all test suites.✨  Done in 2.99s.

@BledaiBledai changed the titleFix: Move changelog empty check after categorization for accuracyfix: Move changelog empty check after categorization for accuracyFeb 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Bledai
[8]ページ先頭
©2009-2025 Movatter.jp