Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add Support for Injecting Configuration Directly into Release Drafter#1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ReneWerner87 wants to merge4 commits intorelease-drafter:master
base:master
Choose a base branch
Loading
fromReneWerner87:master

Conversation

@ReneWerner87
Copy link

@ReneWerner87ReneWerner87 commentedJan 19, 2025•
edited
Loading

This pull request introduces a new feature to the Release Drafter GitHub Action that allows users to inject configuration dynamically during workflow execution.

Fixes#1338,#336

Key Changes

  1. Newconfig Input:

    • Users can now provide the release configuration directly as a string using theconfig input.
    • This eliminates the need for configuration files to be stored in the repository or committed during workflow execution.
    • Theconfig input takes precedence over theconfig-name input if both are provided.

  2. Use Case:

    • Ideal for workflows where configurations are dynamically generated or vary depending on runtime conditions.
    • Avoids unnecessary commits of temporary or environment-specific configuration files. e.g. (gofiber/storage@2aa6a93)

  3. Example:

    • Added documentation with a clear example of how to use the newconfig input to inject configurations directly.

Benefits

  • Enhances flexibility in using the Release Drafter Action.
  • Simplifies workflows by removing the need for file-based configurations in some cases.

kawa-marcin, nicolajv, joonvena, say8425, cmflynn, mdelapenya, cchanche, Gerrit91, and jrbeilke reacted with thumbs up emojicmflynn and sarathas reacted with heart emojicmflynn reacted with eyes emoji
@ReneWerner87
Copy link
Author

ReneWerner87 commentedJan 19, 2025•
edited
Loading

@ReneWerner87
Copy link
Author

@TimonVS@jetersen what are the next steps? do i have to provide anything else?

@ReneWerner87
Copy link
Author

friendly ping ?

@gaby
Copy link

@jetersen@toolmantim@TimonVS Any chance of getting a review for this PR?

It heavily simplifies the usage of release-drafter for mono-repos.

nicolajv, joonvena, gaby, and say8425 reacted with thumbs up emoji

@gaby
Copy link

Hello@jetersen@toolmantim@TimonVS Any chance of getting a review for this PR? We have been trying to reach out for 2 months with no answer.

Thanks!

@say8425
Copy link

This would make it easier to support monorepo. Currently, Ihave to create n number of config files like the code below to use the monorepo feature, which is inconvenient.
https://github.com/guardrail-dev/guardrail/blob/master/.github/workflows/release-drafter.yml

PR doesn't seem to have any issues, is there anything in particular that needs to be reviewed further?

nicolajv, gaby, and mdelapenya reacted with thumbs up emoji

@gaby
Copy link

gaby commentedMay 7, 2025

@say8425 We just waiting for the maintainers, they haven't responded in a while.

@ReneWerner87
Copy link
Author

@mdelapenya
Copy link

@jetersen friendly ping! I knew about this and I'm interested in adopting this pattern in the testcontainers-go monorepo 🙏

Please let me know if you need any kind of support with it

say8425, nicolajv, and gaby reacted with thumbs up emoji

@jrbeilke
Copy link

@und-miller what do you think about this feature/PR?

@und-miller
Copy link
Collaborator

@und-miller what do you think about this feature/PR?

I would want feedback from@jetersen before merging new features as I am not as familiar with the repo.

mdelapenya reacted with heart emoji

@gaby
Copy link

gaby commentedNov 5, 2025

@jrbeilke@und-miller@jetersen We been running this for months in the GoFiber org using a fork. Having this merged would be awesome

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow inputing config-name file contents

6 participants

@ReneWerner87@gaby@say8425@mdelapenya@jrbeilke@und-miller
[8]ページ先頭
©2009-2025 Movatter.jp