Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitfaf4a45

Browse files
authored
Access m2m descriptor using customas value if necessary (#552)
* reproduce failing deletion of m2m field with custom name* access m2m descriptor using custom `as` value if necessary
1 parentdb43524 commitfaf4a45

File tree

2 files changed

+49
-1
lines changed

2 files changed

+49
-1
lines changed

‎src/Model.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,8 @@ const Model = class Model {
762762
constfield=virtualFields[key];
763763
if(fieldinstanceofManyToMany){
764764
// Delete any many-to-many rows the entity is included in.
765-
this[key].clear();
765+
constdescriptorKey=field.as||key;
766+
this[descriptorKey].clear();
766767
}elseif(fieldinstanceofForeignKey){
767768
constrelatedQs=this[key];
768769
if(relatedQs.exists()){

‎src/test/functional/many2many.js‎

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,53 @@ describe("Many to many relationships", () => {
203203

204204
validateRelationState();
205205
});
206+
207+
it("deletes with custom field name",()=>{
208+
constApple=classextendsModel{};
209+
Apple.modelName="Apple";
210+
Apple.fields={
211+
id:attr(),
212+
comparableIds:many({
213+
to:"Orange",
214+
as:"comparables",
215+
relatedName:"comparableIds",
216+
}),
217+
};
218+
219+
constOrange=classextendsModel{};
220+
Orange.modelName="Orange";
221+
Orange.fields={
222+
id:attr(),
223+
};
224+
225+
orm=newORM();
226+
orm.register(Apple,Orange);
227+
session=orm.session();
228+
expect(session.Apple.count()).toBe(0);
229+
expect(session.Orange.count()).toBe(0);
230+
231+
session.Apple.create({id:"a0",comparableIds:[]});
232+
session.Orange.create({id:"o0"});
233+
234+
expect(session.Apple.count()).toBe(1);
235+
session.Apple.first().delete();
236+
expect(session.Apple.count()).toBe(0);
237+
238+
expect(session.Orange.count()).toBe(1);
239+
session.Orange.first().delete();
240+
expect(session.Orange.count()).toBe(0);
241+
242+
session.Apple.create({id:"a0",comparableIds:["o0"]});
243+
session.Orange.create({id:"o0",comparableIds:["a0"]});
244+
245+
expect(session.Apple.count()).toBe(1);
246+
session.Apple.first().delete();
247+
expect(session.Apple.count()).toBe(0);
248+
249+
expect(session.Orange.count()).toBe(1);
250+
session.Orange.first().delete();
251+
expect(session.Orange.count()).toBe(0);
252+
});
206253
});
207254

208255
describe("many-many with a custom through model",()=>{

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp