Commitf9d8518

authored

Do not attempt to delete from non-existing index (#543)

* reproduce upsert erroring when previous virtual field values are undefined* do not attempt to delete from non-existing index

1 parent5849a46 commitf9d8518Copy full SHA for f9d8518

File tree

+16

-1

lines changed

+16

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,7 @@ export class Table {`
`467`	`467`	`// attribute has not changed, no need to update any index`
`468`	`468`	`return;`
`469`	`469`	`}`
`470`		`-if(prevValue!==null){`
	`470`	`+if(prevValue!==null&&typeofprevValue!=="undefined"){`
`471`	`471`	`// remove id from attribute's index for its old value`
`472`	`472`	`indexIdsToDelete.push([attr,prevValue,id]);`
`473`	`473`	`}`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -622,6 +622,21 @@ describe("Immutable session", () => {`
`622`	`622`	`expect(movie.publisher.ref).toBe(newPublisher.ref);`
`623`	`623`	`});`
`624`	`624`
	`625`	`+it("upserting previously empty forwards foreign key (many-to-one) field works",()=>{`
	`626`	`+const{ Movie, Publisher}=session;`
	`627`	`+`
	`628`	`+constpublisher=Publisher.withId(0);`
	`629`	`+`
	`630`	`+constinitialMovie=Movie.create({});`
	`631`	`+constnewMovie=Movie.upsert({`
	`632`	`+id:initialMovie.id,`
	`633`	`+publisherId:publisher.id,`
	`634`	`+});`
	`635`	`+`
	`636`	`+expect(newMovie.publisherId).toEqual(0);`
	`637`	`+expect(newMovie.publisher.ref).toBe(publisher.ref);`
	`638`	`+});`
	`639`	`+`
`625`	`640`	`it("trying to set backwards foreign key (reverse many-to-one) field throws",()=>{`
`626`	`641`	`const{ Book}=session;`
`627`	`642`

Comments

(0)