- Notifications
You must be signed in to change notification settings - Fork103
Support converting all options to twig attributes#859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@Spea Looks good to me. Could you check the failing CI? |
With this change, all potential options from the `TwigFilter` and `TwigFunction` classes will be converted to their counterpart in the attribute, so if you have something like this:```phpclass MyClass{ public function getFilters(): array { return [ new \Twig\TwigFilter('with_environment', $this->withEnvironment(...), ['needs_environment' => true]), ]; } public function withEnvironment(Environment $env, $value) { // ... }}```it will now be converted to the following instead of skipping it:```phpclass MyClass{ #[\Twig\Attribute\AsTwigFilter('with_environment', needsEnvironment: true)] public function withEnvironment(Environment $env, $value) { // ... }}```bb4599e tocc6cff3Compare
Sure, seems like I overlooked some type hints. I added them now and locally |
Thank you, let's ship this 👍 |
7ea6950 intorectorphp:main 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, all potential options from the
TwigFilterandTwigFunctionclasses will be converted to their counterpart in the attribute, so if you have something like this:it will now be converted to the following instead of skipping it: