Commit5b74528

authored

Use random.choice instead of random.randint

random.choice is better for selecting random elements from a list than using random.randint to generate random indices to select

1 parent8eb0735 commit5b74528Copy full SHA for 5b74528

File tree

-8

lines changed

-8

lines changed

Lines changed: 3 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-fromrandomimportrandint`
	`1`	`+fromrandomimportchoice`
`2`	`2`
`3`	`3`
`4`	`4`	`defrandom_name_generator(first,second,x):`
`@@ -10,13 +10,8 @@ def random_name_generator(first, second, x):`
`10`	`10`	`- number of random names`
`11`	`11`	`"""`
`12`	`12`	`names= []`
`13`		`-foriinrange(0,int(x)):`
`14`		`-random_first=randint(0,len(first)-1)`
`15`		`-random_last=randint(0,len(second)-1)`
`16`		`-names.append("{0} {1}".format(`
`17`		`-first[random_first],`
`18`		`-second[random_last])`
`19`		`- )`
	`13`	`+foriinrange(x):`
	`14`	`+names.append("{0} {1}".format(choice(first),choice(second)))`
`20`	`15`	`returnset(names)`
`21`	`16`
`22`	`17`

Comments

(0)