Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork160
SecureConnector: add optional TlsPeer, this...#252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:1.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
After various approaches, this seemed to be the most promising one. However, please let me know in case you want to move it elsewhere. Just in case you're wondering, I also tried to combine this with the <?phpfinalclass ConnectedConnectorimplements ConnectorInterface{private$connection;publicfunction__construct(ConnectionInterface$connection) {$this->connection =$connection; }publicfunctionconnect($uri) {returnresolve($this->connection); }} |
NB: Checks are failing, but for an unrelated reason |
313ca21 to64792e5CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Cool! Thank you for putting the works into this PR 👍 .
P.S. What is your use case for doing this?
Thomas-Gelf commentedSep 27, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@WyriHaximus: glad that you like it! Use case: different ones. Right now I'm using it for an upcomingIcinga module where I want to ask the user to confirm whether he wants to add an unknown CA certificate to it's trust store. Once the CA is confirmed, the (ReactPHP-based) daemon needs to generate a CSR and to deal with the signing process. In future I'd love to also use it for already existing components like ourcertificate monitoring |
@Thomas-Gelf That's pretty amazing! Looking forward to the certificate monitoring component ReactPHP use, feel free to tag me when that comes |
...allows to capture your peer certificate and/or it's chain
64792e5 toe0dcc1aCompare@Thomas-Gelf Thanks for looking into this and filing this PR! Love to see how@reactphp is used as part of@Icinga! Unfortunately, this PR currently uses the internal What are your thoughts on this? I'm also happy to jump on a quick call to discuss this in person if you want (see my profile for details) 👍 |
...allows to capture your peer certificate and/or it's chain