Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Improved logging performance by replacing regular expression#4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
andre161292 wants to merge1 commit intoreactor:main
base:main
Choose a base branch
Loading
fromandre161292:feature/signal-performance

Conversation

@andre161292
Copy link

@andre161292andre161292 commentedOct 22, 2025
edited
Loading

This change improves performance for those using the logging operations of Reactor.

The old implementation usedString#replaceFirst as it's method to replace the package name with an empty String. AsreplaceFirst accepts a regular expression, the evaluation was more expensive.
The new logic utilizes a simple substring search and doesn't create an unnecessary new String, but directly appends to the StringBuilder.

Additionally each dot (.) in the package's name, including the appended dot at the end, was treated as a wildcard, which is unexpected behaviour (i assume).

@andre161292andre161292 requested a review froma team as acode ownerOctober 22, 2025 14:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andre161292

[8]ページ先頭

©2009-2025 Movatter.jp