Commit84bb636

committed

Merge pull requestsigmavirus24#317 from helenst/pull-request-commits

PullRequest.commits returns generator of RepoCommits

2 parents36b4a67 +bda512e commit84bb636Copy full SHA for 84bb636

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`
`11`	`11`	`fromreimportmatch`
`12`	`12`	`fromjsonimportdumps`
`13`		`-from .gitimportCommit`
	`13`	`+from .repos.commitimportRepoCommit`
`14`	`14`	`from .modelsimportGitHubObject,GitHubCore,BaseComment`
`15`	`15`	`from .usersimportUser`
`16`	`16`	`from .decoratorsimportrequires_auth`
`@@ -238,10 +238,11 @@ def commits(self, number=-1, etag=None):`
`238`	`238`	`-1 returns all available commits.`
`239`	`239`	`:param str etag: (optional), ETag from a previous request to the same`
`240`	`240`	`endpoint`
`241`		- :returns: generator of :class:`Commit <github3.git.Commit>`\ s
	`241`	`+ :returns: generator of`
	`242`	+ :class:`RepoCommit <github3.repos.commit.RepoCommit>`\ s
`242`	`243`	`"""`
`243`	`244`	`url=self._build_url('commits',base_url=self._api)`
`244`		`-returnself._iter(int(number),url,Commit,etag=etag)`
	`245`	`+returnself._iter(int(number),url,RepoCommit,etag=etag)`
`245`	`246`
`246`	`247`	`deffiles(self,number=-1,etag=None):`
`247`	`248`	`r"""Iterate over the files associated with this pull request.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ def test_commits(self):`
`31`	`31`	`withself.recorder.use_cassette(cassette_name):`
`32`	`32`	`p=self.get_pull_request()`
`33`	`33`	`forcommitinp.commits():`
`34`		`-assertisinstance(commit,github3.git.Commit)`
	`34`	`+assertisinstance(commit,github3.repos.commit.RepoCommit)`
`35`	`35`
`36`	`36`	`deftest_create_review_comment(self):`
`37`	`37`	`"""Show that a user can create an in-line reveiw comment on a PR."""`

Comments

(0)