NotificationsYou must be signed in to change notification settings
Fork36
Star92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Update judgment-forms caches to use alpha-equivalence.#103

Open

wilbowma wants to merge3 commits intoracket:master

base:master

Choose a base branch

fromwilbowma:alpha-caches

Open

Update judgment-forms caches to use alpha-equivalence.#103

wilbowma wants to merge3 commits intoracket:masterfromwilbowma:alpha-caches

Conversation

Copy link

Collaborator

wilbowma commentedMay 27, 2017

This builds on#102 and should be merged after that PR. Unfortunately, this changedestroys performance. I'm assuming I've done something wrong.

howelland others added3 commits

May 25, 2017 17:39

Update apply-reduction-relation* to be sensitive to alpha-equivalence

1e7ff97

Also add an immutable alpha hash constructor and update hashes inthe gui to use the form provided by binding-forms.rktFixesracket#96

Change judgment-form cache to an α-hash

30bfde1

Changed some missing hashes to α-hashes

bfd6495

Copy link

CollaboratorAuthor

wilbowma commentedMay 27, 2017•
edited
Loading

Regarding the performance issues I was discussing in#102, this test causes serious slow down.
https://github.com/wilbowma/cic-redex/blob/master/cic.rkt#L491

On my machine, it runs in 7s without that test, and ~10 minutes with. It looks like it causes lots of redundant well-formedness checks, all of whichshould be in the cache, but my tests lead me to believe they don't trigger the cache due to alpha equivalence. However, this PR doesn't solve the performance issues; it makes it worse.