Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: Fix a few typos#2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
timgates42 wants to merge1 commit intoquantopian:master
base:master
Choose a base branch
Loading
fromtimgates42:bugfix_typos

Conversation

@timgates42
Copy link
Contributor

There are small typos in:

  • tests/test_assets.py
  • zipline/data/minute_bars.py
  • zipline/errors.py
  • zipline/finance/controls.py

Fixes:

  • Should readconstraint rather thancontraint.
  • Should readslippage rather thanslipage.
  • Should readidentifier rather thanidentifer.
  • Should readconsidered rather thanconsdered.

Semi-automated pull request generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

There are small typos in:- tests/test_assets.py- zipline/data/minute_bars.py- zipline/errors.py- zipline/finance/controls.pyFixes:- Should read `constraint` rather than `contraint`.- Should read `slippage` rather than `slipage`.- Should read `identifier` rather than `identifer`.- Should read `considered` rather than `consdered`.Signed-off-by: Tim Gates <tim.gates@iress.com>
@andycwang
Copy link

andycwang commentedJul 20, 2022 via email

***@***.***邮箱联系我,谢谢!

Copy link

@adamLutPhiadamLutPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Typos arecorrected

@andycwang
Copy link

andycwang commentedSep 16, 2022 via email

***@***.***邮箱联系我,谢谢!

Copy link

@adamLutPhiadamLutPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code has been Reviewed:typos has beenfixed

timgates42 reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@adamLutPhiadamLutPhiadamLutPhi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timgates42@andycwang@adamLutPhi

[8]ページ先頭

©2009-2025 Movatter.jp