- Notifications
You must be signed in to change notification settings - Fork108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Models#215
Open
sowelipililimute wants to merge1 commit intoqmlnet:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Models#215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Ping? |
Oh, sorry, I didn't realize this was ready for review. I will try to get to it this week, this weekend at the latest. |
ec4d7fd to2bbc873CompareIt's not required on your part, but if you have time, I'd like to see some unit tests that both test and demonstrate what you've done. By the way, good work! |
It looks like the native code is failing a build on Windows. |
|
Merged. |
looks like this builds now |
How does this change the API of working with models? |
This exposes the usual slew of Qt model classes, which allows them to be used from C#. I would recommend reading Qt docs:https://doc.qt.io/qt-5/model-view-programming.html |
I've been using those for a decade so I'm pretty familiar, but there is no documentation here - add examples how it would look? |
585f8d9 to841ad96Compare
doc comments added |
841ad96 toa7daec0Comparethank you |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the minimum recommended APIs necessary to implement read-only models in C# that can interop with QML, handling 90% of usecases for models.
Depends onqmlnet/qmlnet-native#1.