- Notifications
You must be signed in to change notification settings - Fork4.3k
Add clarifying notes to polynomial tutorials about fit limitations#3668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
patrocinio wants to merge2 commits intopytorch:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
pytorch-botbot commentedNov 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🔗 Helpful Links🧪 See artifacts and rendered test results athud.pytorch.org/pr/pytorch/tutorials/3668
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commitee9fb00 with merge base7f8b6dc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Addresses feedback that the 3rd-degree polynomial fit for sin(x) over [-π, π]may be confusing for beginners. Added educational notes explaining that:- The example demonstrates gradient descent mechanics, not perfect fitting- 3rd-degree polynomials have mathematical limitations for this task- Higher-order terms (5th, 7th degree) are needed for better accuracy- The imperfect fit is expected and teaches model architecture selection
9dde6aa to7ae350aCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback that the 3rd-degree polynomial fit for sin(x) over [-π, π] may be confusing for beginners. Added educational notes explaining that:
Fixes#3607
Description
Checklist