NotificationsYou must be signed in to change notification settings
Fork424
Star3.2k

[Feature] Add NPU Support for Single Agent#3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

lowdy1 wants to merge1 commit intopytorch:main

base:main

Choose a base branch

fromlowdy1:npu

Open

[Feature] Add NPU Support for Single Agent#3229

lowdy1 wants to merge1 commit intopytorch:mainfromlowdy1:npu

Conversation

Copy link

Contributor

lowdy1 commentedNov 4, 2025

Description

Adds support for Ascend NPUs in most single-agent sota-implementations. These changes are non-intrusive to existing code and have been thoroughly tested on Ascend NPU devices.
As the next step, we are working to extend TorchRL NPU support to multi-agent experiments and GRPO, and we plan to submit a separate PR for this work soon.

Motivation and Context

We aim to extend TorchRL to enable execution on NPUs, providing broader hardware compatibility.
And our issue is#3154

I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds core functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (update in the documentation)
Example (update in the folder of examples)

Checklist

Go over all the following points, and put anx in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

I have read theCONTRIBUTION guide (required)
My change requires a change to the documentation.
I have updated the tests accordingly (required for a bug fix or a new feature).
I have updated the documentation accordingly.

Add NPU Support for Single Agent

94b95e2

Copy link

pytorch-botbot commentedNov 4, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/pytorch/rl/3229

📄 PreviewPython docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 1 Cancelled Job, 8 Unrelated Failures

As of commit94b95e2 with merge basea0d650f ():

NEW FAILURES - The following jobs have failed:

Build Linux Wheels / pytorch/rl (pytorch/rl, test/smoke_test.py, torchrl, .github/scripts/pre-build-script.sh) / build-manywheel-py3_10-rocm6_4 (gh)
Build Linux Wheels / pytorch/rl (pytorch/rl, test/smoke_test.py, torchrl, .github/scripts/pre-build-script.sh) / upload / upload-manywheel-py3_10-rocm6_4 (gh)
Unable to download artifact(s): Artifact not found for name: pytorch_rl__3.10_rocm6.4_x86_64
Continuous Benchmark (PR) / CPU Pytest benchmark (gh)
Workflow failed! Resource not accessible by integration
Habitat Tests on Linux / tests (3.9, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t adb3064e65800fa6b9e21da6527c6c104427a473e66627584503d83d2cd4eb7d /exec failed with exit code 1
Libs Tests on Linux / unittests-gym (3.9, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t 5895e7943ea51dea5990fcfb433b8c7650f074a59d8d6319c3ceba8b34876ed6 /exec failed with exit code 1
Push Binary Nightly / build-wheel-unix (linux, ubuntu-22.04, 3.9, cp39-cp39, cpu, cpu) (gh)
Push Binary Nightly / build-wheel-unix (macos, macos-latest, 3.9, cp39-cp39, cpu, cpu) (gh)
SOTA Tests on Linux / tests (3.9, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t 52b4a9b7983c19ba1bc7e5c400e164e0566bfdf3a5ef7138cf7f03e47884d521 /exec failed with exit code 1
Unit-tests on Linux / tests-gpu (3.11, 12.8) / linux-job (gh)
test/test_collector.py::TestPolicyFactory::test_weight_update[scheme_shared]
Unit-tests on Linux / tests-olddeps (3.9, 11.6) / linux-job (gh)
test/test_collector.py::TestPolicyFactory::test_weight_update[scheme_shared]
Unit-tests on Linux / tests-optdeps (3.11, 12.8) / linux-job (gh)
test/test_collector.py::TestCollectorGeneric::test_update_weights[SharedMemWeightSyncScheme-True-True]
Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job (gh)
test/test_collector.py::TestPolicyFactory::test_weight_update[scheme_shared]

CANCELLED JOB - The following job was cancelled. Please retry:

Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
##[error]The operation was canceled.

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉Rebase onto the `viable/strict` branch to avoid these failures

Push Binary Nightly / build-wheel-windows (3.9, 3.9) (gh) (trunk failure)
Process completed with exit code 1.
Push Binary Nightly / test-wheel-unix (linux, ubuntu-22.04, 3.9, cp39-cp39, cpu, cpu) (gh) (trunk failure)
Process completed with exit code 1.
Push Binary Nightly / test-wheel-unix (macos, macos-latest, 3.9, cp39-cp39, cpu, cpu) (gh) (trunk failure)
Process completed with exit code 1.
Push Binary Nightly / test-wheel-windows (3.9, 3.9) (gh) (trunk failure)
Process completed with exit code 1.
Unit-tests on Linux / tests-cpu (3.10) / linux-job (gh) (trunk failure)
test/test_collector.py::TestAutoWrap::test_auto_wrap_error[SyncDataCollector-1]
Unit-tests on Linux / tests-cpu (3.11) / linux-job (gh) (trunk failure)
test/test_collector.py::TestAutoWrap::test_auto_wrap_error[SyncDataCollector-1]
Unit-tests on Linux / tests-cpu (3.12) / linux-job (gh) (trunk failure)
test/test_collector.py::TestAutoWrap::test_auto_wrap_error[SyncDataCollector-1]
Unit-tests on Linux / tests-cpu (3.9) / linux-job (gh) (trunk failure)
test/test_collector.py::TestAutoWrap::test_auto_wrap_error[SyncDataCollector-1]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-clabot added the CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label

Nov 4, 2025

lowdy1 changed the title~~Add NPU Support for Single Agent~~[Feature] Add NPU Support for Single Agent

Nov 5, 2025

Labels

CLA Signed

This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Feature] Add NPU Support for Single Agent#3229

Are you sure you want to change the base?

[Feature] Add NPU Support for Single Agent#3229

Uh oh!

Conversation

lowdy1 commentedNov 4, 2025

Description

Motivation and Context

Types of changes

Checklist

Uh oh!

pytorch-botbot commentedNov 4, 2025•
edited
Loading

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/pytorch/rl/3229

❌ 12 New Failures, 1 Cancelled Job, 8 Unrelated Failures

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Movatterモバイル変換

[Feature] Add NPU Support for Single Agent#3229

Are you sure you want to change the base?

[Feature] Add NPU Support for Single Agent#3229

Uh oh!

Conversation

lowdy1 commentedNov 4, 2025

Description

Motivation and Context

Types of changes

Checklist

Uh oh!

pytorch-botbot commentedNov 4, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/pytorch/rl/3229

❌ 12 New Failures, 1 Cancelled Job, 8 Unrelated Failures

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pytorch-botbot commentedNov 4, 2025•
edited
Loading