NotificationsYou must be signed in to change notification settings
Fork424
Star3.2k

[Refactor] Pass all keys at reset (prototype)#2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

vmoens wants to merge1 commit intomain

base:main

Choose a base branch

fromfix-reset-hide-keys

Open

[Refactor] Pass all keys at reset (prototype)#2956

vmoens wants to merge1 commit intomainfromfix-reset-hide-keys

Conversation

Copy link

Collaborator

vmoens commentedMay 15, 2025

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntaxclose #15213 if this solves the issue #15213

I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds core functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (update in the documentation)
Example (update in the folder of examples)

Checklist

Go over all the following points, and put anx in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

I have read theCONTRIBUTION guide (required)
My change requires a change to the documentation.
I have updated the tests accordingly (required for a bug fix or a new feature).
I have updated the documentation accordingly.

[Refactor] Pass all keys at reset (prototype)

fabb966

Copy link

pytorch-botbot commentedMay 15, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/pytorch/rl/2956

📄 PreviewPython docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 5 Unrelated Failures

As of commitfabb966 with merge base36f34da ():

NEW FAILURES - The following jobs have failed:

Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
Process completed with exit code 1.
Habitat Tests on Linux / tests (3.9, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t 071dee8713decbe2af1ea6b24a5801d659bf4a4ad70fa610a3e6db952b373950 /exec failed with exit code 1
Libs Tests on Linux / unittests-gym (3.9, 12.8) / linux-job (gh)
test/test_libs.py::TestGym::test_vecenvs_nan
Lint / python-source-and-configs / linux-job (gh)
RuntimeError: Command docker exec -t f0e5fa9cc8eb1f3e3f52c328216ede849f668c4dc6392cfb4cf15c9825b55c0a /exec failed with exit code 1
Unit-tests on Linux / tests-cpu (3.10) / linux-job (gh)
test/test_transforms.py::TestMultiAction::test_transform_env[False]
Unit-tests on Linux / tests-cpu (3.11) / linux-job (gh)
test/test_transforms.py::TestMultiAction::test_transform_env[False]
Unit-tests on Linux / tests-cpu (3.12) / linux-job (gh)
test/test_transforms.py::TestMultiAction::test_transform_env[False]
Unit-tests on Linux / tests-cpu (3.9) / linux-job (gh)
test/test_transforms.py::TestMultiAction::test_transform_env[False]
Unit-tests on Linux / tests-gpu (3.11, 12.8) / linux-job (gh)
test/test_transforms.py::TestMultiAction::test_transform_env[False]
Unit-tests on Linux / tests-olddeps (3.9, 11.6) / linux-job (gh)
test/test_transforms.py::TestMultiAction::test_transform_env[False]
Unit-tests on Linux / tests-optdeps (3.11, 12.8) / linux-job (gh)
test/test_transforms.py::TestMultiAction::test_transform_env[False]
Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job (gh)
test/test_transforms.py::TestMultiAction::test_transform_env[False]

FLAKY - The following job failed but was likely due to flakiness present on trunk:

Continuous Benchmark (PR) / CPU Pytest benchmark (gh) (similar failure)

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉Rebase onto the `viable/strict` branch to avoid these failures

Continuous Benchmark / CPU Pytest benchmark (gh) (trunk failure)
Continuous Benchmark / GPU Pytest benchmark (gh) (trunk failure)
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor []] is at version 4; expected version 3 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).
LLM Tests on Linux / unittests (3.9, 12.8) / linux-job (gh) (trunk failure)
##[error]The operation was canceled.
Unit-tests on Windows / unittests-cpu (3.10, windows.4xlarge, cpu) / windows-job (gh) (trunk failure)
test/test_transforms.py::TestTimer::test_transform_env

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label

May 15, 2025

Copy link

facebook-github-bot commentedMay 23, 2025

Hi@vmoens!

Thank you for your pull request.

Werequire contributors to sign ourContributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to beresubmitted.

Process

In order for us to review and merge your suggested changes, please sign athttps://code.facebook.com/cla.If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, thepull request will be tagged withCLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us atcla@meta.com. Thanks!

Labels

CLA Signed

This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Refactor] Pass all keys at reset (prototype)#2956

Are you sure you want to change the base?

[Refactor] Pass all keys at reset (prototype)#2956

Uh oh!

Conversation

vmoens commentedMay 15, 2025

Description

Motivation and Context

Types of changes

Checklist

Uh oh!

pytorch-botbot commentedMay 15, 2025•
edited
Loading

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/pytorch/rl/2956

❌ 12 New Failures, 5 Unrelated Failures

Uh oh!

facebook-github-bot commentedMay 23, 2025

Process

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Movatterモバイル変換

[Refactor] Pass all keys at reset (prototype)#2956

Are you sure you want to change the base?

[Refactor] Pass all keys at reset (prototype)#2956

Uh oh!

Conversation

vmoens commentedMay 15, 2025

Description

Motivation and Context

Types of changes

Checklist

Uh oh!

pytorch-botbot commentedMay 15, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/pytorch/rl/2956

❌ 12 New Failures, 5 Unrelated Failures

Uh oh!

facebook-github-bot commentedMay 23, 2025

Process

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-botbot commentedMay 15, 2025•
edited
Loading