NotificationsYou must be signed in to change notification settings
Fork750
Star2.8k

For rocm, atol is reduced for gradcheck of oscillator_test to pass wh…#3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

amd-sriram wants to merge1 commit intopytorch:main

base:main

Choose a base branch

fromROCm:rocm_fix_oscillator_test

Open

For rocm, atol is reduced for gradcheck of oscillator_test to pass wh…#3930

amd-sriram wants to merge1 commit intopytorch:mainfromROCm:rocm_fix_oscillator_test

Conversation

Copy link

amd-sriram commentedJun 12, 2025

For rocm, atol is reduced for gradcheck of oscillator_test to pass when using slow mode.

Tested on rocm and nvidia

For rocm, atol is reduced for gradcheck of oscillator_test to pass wh…

2ede2ee

…en using slow mode.

amd-sriram requested a review froma team as acode owner

June 12, 2025 10:43

Copy link

pytorch-botbot commentedJun 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/pytorch/audio/3930

📄 PreviewPython docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-botbot added the module: rocm label

Jun 12, 2025

Copy link

Contributor

facebook-github-bot commentedJun 12, 2025

Hi@amd-sriram!

Thank you for your pull request and welcome to our community.

Action Required

In order to mergeany pull request (code, docs, etc.), werequire contributors to sign ourContributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign athttps://code.facebook.com/cla.If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, thepull request will be tagged withCLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us atcla@meta.com. Thanks!