- Notifications
You must be signed in to change notification settings - Fork376
Dynamic memory allocation#3727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cehongwang wants to merge6 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/home/runner/work/TensorRT/TensorRT/core/runtime/register_jit_hooks.cpp b/tmp/changes.txtindex 6d15bd8..b6f2d5b 100644--- a/home/runner/work/TensorRT/TensorRT/core/runtime/register_jit_hooks.cpp+++ b/tmp/changes.txt@@ -109,7 +109,10 @@ static auto TORCHTRT_UNUSED TRTEngineTSRegistrtion = [](const c10::intrusive_ptr<TRTEngine>& self) -> std::vector<std::string> { return self->serialize(); }, [](std::vector<std::string> serialized_info) -> c10::intrusive_ptr<TRTEngine> { serialized_info[ENGINE_IDX] = base64_decode(serialized_info[ENGINE_IDX]);- LOG_DEBUG("Deserialized resource allocation strategy: " << (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX])) ? "Dynamic" : "Static"));+ LOG_DEBUG(+ "Deserialized resource allocation strategy: "+ << (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX])) ? "Dynamic"+ : "Static")); TRTEngine::verify_serialization_fmt(serialized_info); return c10::make_intrusive<TRTEngine>(serialized_info); });diff --git a/home/runner/work/TensorRT/TensorRT/core/runtime/TRTEngine.cpp b/tmp/changes.txtindex 253738b..de70331 100644--- a/home/runner/work/TensorRT/TensorRT/core/runtime/TRTEngine.cpp+++ b/tmp/changes.txt@@ -86,7 +86,9 @@ TRTEngine::TRTEngine(std::vector<std::string> serialized_info) static_cast<bool>(std::stoi(serialized_info[HW_COMPATIBLE_IDX])), static_cast<bool>(std::stoi(serialized_info[REQUIRES_OUTPUT_ALLOCATOR_IDX])), serialized_info[SERIALIZED_METADATA_IDX],- (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX])) ? ResourceAllocationStrategy::kDynamic : ResourceAllocationStrategy::kStatic)) {}+ (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX]))+ ? ResourceAllocationStrategy::kDynamic+ : ResourceAllocationStrategy::kStatic)) {}TRTEngine::TRTEngine( const std::string& mod_name,@@ -129,7 +131,9 @@ TRTEngine::TRTEngine( } this->resource_allocation_strategy = resource_allocation_strategy;- LOG_DEBUG("Resource allocation strategy: " << (this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "Dynamic" : "Static"));+ LOG_DEBUG(+ "Resource allocation strategy: "+ << (this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "Dynamic" : "Static")); if (this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic) { this->exec_ctx = make_trt(cuda_engine->createExecutionContext(nvinfer1::ExecutionContextAllocationStrategy::kUSER_MANAGED));@@ -472,7 +476,8 @@ std::vector<std::string> TRTEngine::serialize() { serialized_info[REQUIRES_OUTPUT_ALLOCATOR_IDX] = this->requires_output_allocator ? "1" : "0"; serialized_info[SERIALIZED_METADATA_IDX] = this->serialized_metadata; serialized_info[TARGET_PLATFORM_IDX] = this->target_platform.serialize();- serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX] = this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "1" : "0";+ serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX] =+ this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "1" : "0"; return serialized_info;}@@ -486,11 +491,11 @@ void TRTEngine::set_resource_allocation_strategy(TRTEngine::ResourceAllocationSt this->resource_allocation_strategy = new_strategy; if (this->resource_allocation_strategy == TRTEngine::ResourceAllocationStrategy::kDynamic) { LOG_DEBUG("Setting resource allocation strategy to dynamic");- this->exec_ctx = make_trt(cuda_engine->createExecutionContext(nvinfer1::ExecutionContextAllocationStrategy::kUSER_MANAGED));+ this->exec_ctx =+ make_trt(cuda_engine->createExecutionContext(nvinfer1::ExecutionContextAllocationStrategy::kUSER_MANAGED)); } else { LOG_DEBUG("Setting resource allocation strategy to static");- this->exec_ctx = make_trt(- cuda_engine->createExecutionContext());+ this->exec_ctx = make_trt(cuda_engine->createExecutionContext()); } }}ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/examples/dynamo/dynamic_memory_allocation.py2025-07-29 23:34:54.135102+00:00+++ /home/runner/work/TensorRT/TensorRT/examples/dynamo/dynamic_memory_allocation.py2025-07-29 23:35:18.839735+00:00@@ -14,21 +14,22 @@ "ir": "dynamo", "use_python_runtime": False, "enabled_precisions": {torch.float32}, "immutable_weights": False, "lazy_engine_init": True,- "dynamically_allocate_resources": True-+ "dynamically_allocate_resources": True,}model = models.resnet152(pretrained=True).eval().to("cuda")compiled_module = torch_trt.compile(model, inputs=inputs, **settings)print((torch.cuda.mem_get_info()[1] - torch.cuda.mem_get_info()[0]) / 1024**3)compiled_module(*inputs)time.sleep(30)-with torch_trt.dynamo.runtime.ResourceAllocationStrategy(compiled_module, dynamically_allocate_resources=False):+with torch_trt.dynamo.runtime.ResourceAllocationStrategy(+ compiled_module, dynamically_allocate_resources=False+): print( "Memory used (GB):", (torch.cuda.mem_get_info()[1] - torch.cuda.mem_get_info()[0]) / 1024**3, ) compiled_module(*inputs)--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/runtime/_ResourceAllocator.py2025-07-29 23:34:54.152102+00:00+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/runtime/_ResourceAllocator.py2025-07-29 23:35:20.711155+00:00@@ -12,21 +12,25 @@ """ def __init__( self, compiled_module: torch.nn.Module,- dynamically_allocate_resources: bool = True+ dynamically_allocate_resources: bool = True, ) -> None: super(ResourceAllocationStrategy, self).__init__() self.compiled_module = compiled_module self.dynamically_allocate_resources = dynamically_allocate_resources def __enter__(self) -> None: print("Entering resource allocator context") for name, submodule in self.compiled_module.named_modules(): if "_run_on_acc" in name:- submodule.use_dynamically_allocated_resources(dynamically_allocate_resources=self.dynamically_allocate_resources)+ submodule.use_dynamically_allocated_resources(+ dynamically_allocate_resources=self.dynamically_allocate_resources+ ) def __exit__(self, exc_type: Any, exc_value: Any, exc_tb: Any) -> None: for name, submodule in self.compiled_module.named_modules(): if "_run_on_acc" in name:- submodule.use_dynamically_allocated_resources(dynamically_allocate_resources=self.dynamically_allocate_resources)+ submodule.use_dynamically_allocated_resources(+ dynamically_allocate_resources=self.dynamically_allocate_resources+ )--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/runtime/_TorchTensorRTModule.py2025-07-29 23:34:54.152102+00:00+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/runtime/_TorchTensorRTModule.py2025-07-29 23:35:21.044122+00:00@@ -186,11 +186,13 @@ engine_info[SERIALIZED_METADATA_IDX] = self.encode_metadata(metadata) engine_info[TARGET_PLATFORM_IDX] = target_platform._to_serialized_rt_platform() engine_info[REQUIRES_OUTPUT_ALLOCATOR_IDX] = str( int(self.requires_output_allocator) )- print(f"PROVIDED RESOURCE ALLOCATION STRATEGY: {self.dynamically_allocate_resources}")+ print(+ f"PROVIDED RESOURCE ALLOCATION STRATEGY: {self.dynamically_allocate_resources}"+ ) engine_info[RESOURCE_ALLOCATION_STRATEGY_IDX] = str( int(self.dynamically_allocate_resources) ) print(engine_info[RESOURCE_ALLOCATION_STRATEGY_IDX])@@ -219,13 +221,17 @@ return budget_bytes def _reset_captured_graph(self) -> None: self.engine.reset_captured_graph()- def use_dynamically_allocated_resources(self, dynamically_allocate_resources: bool = False) -> None:+ def use_dynamically_allocated_resources(+ self, dynamically_allocate_resources: bool = False+ ) -> None: self.dynamically_allocate_resources = dynamically_allocate_resources- self.engine.use_dynamically_allocated_resources(self.dynamically_allocate_resources)+ self.engine.use_dynamically_allocated_resources(+ self.dynamically_allocate_resources+ ) def setup_engine(self) -> None: """ Setup engine for a module which has deferred engine setup.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Collaborator
narendasan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add some tests cases for the new API at least for Python?
Uh oh!
There was an error while loading.Please reload this page.
narendasan approved these changesOct 9, 2025
Collaborator
narendasan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor changes then LGTM pending tests
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
9351629 to271525bCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/home/runner/work/TensorRT/TensorRT/core/runtime/register_jit_hooks.cpp b/tmp/changes.txtindex 6d15bd8..b6f2d5b 100644--- a/home/runner/work/TensorRT/TensorRT/core/runtime/register_jit_hooks.cpp+++ b/tmp/changes.txt@@ -109,7 +109,10 @@ static auto TORCHTRT_UNUSED TRTEngineTSRegistrtion = [](const c10::intrusive_ptr<TRTEngine>& self) -> std::vector<std::string> { return self->serialize(); }, [](std::vector<std::string> serialized_info) -> c10::intrusive_ptr<TRTEngine> { serialized_info[ENGINE_IDX] = base64_decode(serialized_info[ENGINE_IDX]);- LOG_DEBUG("Deserialized resource allocation strategy: " << (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX])) ? "Dynamic" : "Static"));+ LOG_DEBUG(+ "Deserialized resource allocation strategy: "+ << (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX])) ? "Dynamic"+ : "Static")); TRTEngine::verify_serialization_fmt(serialized_info); return c10::make_intrusive<TRTEngine>(serialized_info); });diff --git a/home/runner/work/TensorRT/TensorRT/core/runtime/TRTEngine.cpp b/tmp/changes.txtindex 253738b..de70331 100644--- a/home/runner/work/TensorRT/TensorRT/core/runtime/TRTEngine.cpp+++ b/tmp/changes.txt@@ -86,7 +86,9 @@ TRTEngine::TRTEngine(std::vector<std::string> serialized_info) static_cast<bool>(std::stoi(serialized_info[HW_COMPATIBLE_IDX])), static_cast<bool>(std::stoi(serialized_info[REQUIRES_OUTPUT_ALLOCATOR_IDX])), serialized_info[SERIALIZED_METADATA_IDX],- (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX])) ? ResourceAllocationStrategy::kDynamic : ResourceAllocationStrategy::kStatic)) {}+ (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX]))+ ? ResourceAllocationStrategy::kDynamic+ : ResourceAllocationStrategy::kStatic)) {}TRTEngine::TRTEngine( const std::string& mod_name,@@ -129,7 +131,9 @@ TRTEngine::TRTEngine( } this->resource_allocation_strategy = resource_allocation_strategy;- LOG_DEBUG("Resource allocation strategy: " << (this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "Dynamic" : "Static"));+ LOG_DEBUG(+ "Resource allocation strategy: "+ << (this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "Dynamic" : "Static")); if (this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic) { this->exec_ctx = make_trt(cuda_engine->createExecutionContext(nvinfer1::ExecutionContextAllocationStrategy::kUSER_MANAGED));@@ -472,7 +476,8 @@ std::vector<std::string> TRTEngine::serialize() { serialized_info[REQUIRES_OUTPUT_ALLOCATOR_IDX] = this->requires_output_allocator ? "1" : "0"; serialized_info[SERIALIZED_METADATA_IDX] = this->serialized_metadata; serialized_info[TARGET_PLATFORM_IDX] = this->target_platform.serialize();- serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX] = this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "1" : "0";+ serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX] =+ this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "1" : "0"; return serialized_info;}@@ -486,11 +491,11 @@ void TRTEngine::set_resource_allocation_strategy(TRTEngine::ResourceAllocationSt this->resource_allocation_strategy = new_strategy; if (this->resource_allocation_strategy == TRTEngine::ResourceAllocationStrategy::kDynamic) { LOG_DEBUG("Setting resource allocation strategy to dynamic");- this->exec_ctx = make_trt(cuda_engine->createExecutionContext(nvinfer1::ExecutionContextAllocationStrategy::kUSER_MANAGED));+ this->exec_ctx =+ make_trt(cuda_engine->createExecutionContext(nvinfer1::ExecutionContextAllocationStrategy::kUSER_MANAGED)); } else { LOG_DEBUG("Setting resource allocation strategy to static");- this->exec_ctx = make_trt(- cuda_engine->createExecutionContext());+ this->exec_ctx = make_trt(cuda_engine->createExecutionContext()); } }}ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/runtime/_ResourceAllocator.py2025-10-13 06:18:39.245184+00:00+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/runtime/_ResourceAllocator.py2025-10-13 06:19:16.539788+00:00@@ -12,21 +12,25 @@ """ def __init__( self, compiled_module: torch.nn.Module,- dynamically_allocate_resources: bool = True+ dynamically_allocate_resources: bool = True, ) -> None: super(ResourceAllocationStrategy, self).__init__() self.compiled_module = compiled_module self.dynamically_allocate_resources = dynamically_allocate_resources def __enter__(self) -> None: print("Entering resource allocator context") for name, submodule in self.compiled_module.named_modules(): if "_run_on_acc" in name:- submodule.use_dynamically_allocated_resources(dynamically_allocate_resources=self.dynamically_allocate_resources)+ submodule.use_dynamically_allocated_resources(+ dynamically_allocate_resources=self.dynamically_allocate_resources+ ) def __exit__(self, exc_type: Any, exc_value: Any, exc_tb: Any) -> None: for name, submodule in self.compiled_module.named_modules(): if "_run_on_acc" in name:- submodule.use_dynamically_allocated_resources(dynamically_allocate_resources=self.dynamically_allocate_resources)+ submodule.use_dynamically_allocated_resources(+ dynamically_allocate_resources=self.dynamically_allocate_resources+ )
narendasan approved these changesOct 16, 2025
Collaborator
narendasan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/home/runner/work/TensorRT/TensorRT/core/runtime/register_jit_hooks.cpp b/tmp/changes.txtindex 6d15bd8..b6f2d5b 100644--- a/home/runner/work/TensorRT/TensorRT/core/runtime/register_jit_hooks.cpp+++ b/tmp/changes.txt@@ -109,7 +109,10 @@ static auto TORCHTRT_UNUSED TRTEngineTSRegistrtion = [](const c10::intrusive_ptr<TRTEngine>& self) -> std::vector<std::string> { return self->serialize(); }, [](std::vector<std::string> serialized_info) -> c10::intrusive_ptr<TRTEngine> { serialized_info[ENGINE_IDX] = base64_decode(serialized_info[ENGINE_IDX]);- LOG_DEBUG("Deserialized resource allocation strategy: " << (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX])) ? "Dynamic" : "Static"));+ LOG_DEBUG(+ "Deserialized resource allocation strategy: "+ << (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX])) ? "Dynamic"+ : "Static")); TRTEngine::verify_serialization_fmt(serialized_info); return c10::make_intrusive<TRTEngine>(serialized_info); });diff --git a/home/runner/work/TensorRT/TensorRT/core/runtime/TRTEngine.cpp b/tmp/changes.txtindex 253738b..de70331 100644--- a/home/runner/work/TensorRT/TensorRT/core/runtime/TRTEngine.cpp+++ b/tmp/changes.txt@@ -86,7 +86,9 @@ TRTEngine::TRTEngine(std::vector<std::string> serialized_info) static_cast<bool>(std::stoi(serialized_info[HW_COMPATIBLE_IDX])), static_cast<bool>(std::stoi(serialized_info[REQUIRES_OUTPUT_ALLOCATOR_IDX])), serialized_info[SERIALIZED_METADATA_IDX],- (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX])) ? ResourceAllocationStrategy::kDynamic : ResourceAllocationStrategy::kStatic)) {}+ (static_cast<bool>(std::stoi(serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX]))+ ? ResourceAllocationStrategy::kDynamic+ : ResourceAllocationStrategy::kStatic)) {}TRTEngine::TRTEngine( const std::string& mod_name,@@ -129,7 +131,9 @@ TRTEngine::TRTEngine( } this->resource_allocation_strategy = resource_allocation_strategy;- LOG_DEBUG("Resource allocation strategy: " << (this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "Dynamic" : "Static"));+ LOG_DEBUG(+ "Resource allocation strategy: "+ << (this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "Dynamic" : "Static")); if (this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic) { this->exec_ctx = make_trt(cuda_engine->createExecutionContext(nvinfer1::ExecutionContextAllocationStrategy::kUSER_MANAGED));@@ -472,7 +476,8 @@ std::vector<std::string> TRTEngine::serialize() { serialized_info[REQUIRES_OUTPUT_ALLOCATOR_IDX] = this->requires_output_allocator ? "1" : "0"; serialized_info[SERIALIZED_METADATA_IDX] = this->serialized_metadata; serialized_info[TARGET_PLATFORM_IDX] = this->target_platform.serialize();- serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX] = this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "1" : "0";+ serialized_info[RESOURCE_ALLOCATION_STRATEGY_IDX] =+ this->resource_allocation_strategy == ResourceAllocationStrategy::kDynamic ? "1" : "0"; return serialized_info;}@@ -486,11 +491,11 @@ void TRTEngine::set_resource_allocation_strategy(TRTEngine::ResourceAllocationSt this->resource_allocation_strategy = new_strategy; if (this->resource_allocation_strategy == TRTEngine::ResourceAllocationStrategy::kDynamic) { LOG_DEBUG("Setting resource allocation strategy to dynamic");- this->exec_ctx = make_trt(cuda_engine->createExecutionContext(nvinfer1::ExecutionContextAllocationStrategy::kUSER_MANAGED));+ this->exec_ctx =+ make_trt(cuda_engine->createExecutionContext(nvinfer1::ExecutionContextAllocationStrategy::kUSER_MANAGED)); } else { LOG_DEBUG("Setting resource allocation strategy to static");- this->exec_ctx = make_trt(- cuda_engine->createExecutionContext());+ this->exec_ctx = make_trt(cuda_engine->createExecutionContext()); } }}ERROR: Some files do not conform to style guidelines
427e3b8 toceb8afbCompareCo-authored-by: Adrian Wang <123616592+cehongwang@users.noreply.github.com>
ceb8afb tob5355efCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
cla signedcomponent: api [Python]Issues re: Python API component: coreIssues re: The core compiler component: dynamoIssues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtimecomponent: testsIssues re: Tests
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: