Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add EmbeddingSpMDMNBitRowWiseSparse autovectorized variant#5244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
MatzeB wants to merge1 commit intopytorch:main
base:main
Choose a base branch
Loading
fromMatzeB:export-D89086019

Conversation

@MatzeB
Copy link
Contributor

Summary:
X-link:https://github.com/facebookresearch/FBGEMM/pull/2235

This adds an autovectorized implementation of theGenerateEmbeddingSpMDMNBitRowWiseSparse kernels.

This first version is around 10x improvement compared to the reference C++ implementation, but slower than the asmjit verison (which is x86 only), see list below for how to close this gap:

Room for further enhacements (see some of the surrounding kernels that do implement them):

  • This is only specialized forbit_rate right now. Specializing for common block sizes typically nets good improvements.
  • Directly operates on theout buffer. This is good for unknown block-sizes, but if we specialize for fixed small block-sizes then a separate buffer is better as it can be promoted completely to vector registers (for fixed vector register size anyway, doesn't work for variable size AArch64 SVE registers).
  • No prefetching logic yet.

Differential Revision: D89086019

Summary:X-link:facebookresearch/FBGEMM#2235This adds an autovectorized implementation of the `GenerateEmbeddingSpMDMNBitRowWiseSparse` kernels.This first version is around 10x improvement compared to the reference C++ implementation, but slower than the asmjit verison (which is x86 only), see list below for how to close this gap:Room for further enhacements (see some of the surrounding kernels that do implement them):- This is only specialized for `bit_rate` right now. Specializing for common block sizes typically nets good improvements.- Directly operates on the `out` buffer. This is good for unknown block-sizes, but if we specialize for fixed small block-sizes then a separate buffer is better as it can be promoted completely to vector registers (for fixed vector register size anyway, doesn't work for variable size AArch64 SVE registers).- No prefetching logic yet.Differential Revision: D89086019
@meta-codesync
Copy link
Contributor

@MatzeB hasexported this pull request. If you are a Meta employee, you can view the originating Diff inD89086019.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MatzeB

[8]ページ先頭

©2009-2025 Movatter.jp