- Notifications
You must be signed in to change notification settings - Fork696
Change to TORCH_CHECK_VALUE for sparse ops#5215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
+11 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
Summary:X-link:facebookresearch/FBGEMM#2212Change to use [`TORCH_CHECK_VALUE`](https://fburl.com/code/xxeanfi2) for sparse ops so that the error can be correctly classified correctly and avoid unnecessary job retries.Reviewed By: q10Differential Revision: D88918840
Contributor
This pull request has been merged in1f570dd. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link:https://github.com/facebookresearch/FBGEMM/pull/2212
Change to use
TORCH_CHECK_VALUEfor sparse ops so that the error can be correctly classified correctly and avoid unnecessary job retries.Reviewed By: q10
Differential Revision: D88918840