Commitd146cc9

authored

Merge pull requestsigmavirus24#920 from tobiashenkel/default-read-timeout

Increase default read timeout to 10 seconds

2 parents08fde31 +080e815 commitd146cc9Copy full SHA for d146cc9

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ class GitHubSession(requests.Session):`
`93`	`93`	`"two_factor_auth_cb",`
`94`	`94`	`]`
`95`	`95`
`96`		`-def__init__(self,default_connect_timeout=4,default_read_timeout=1):`
	`96`	`+def__init__(self,default_connect_timeout=4,default_read_timeout=10):`
`97`	`97`	`"""Slightly modify how we initialize our session."""`
`98`	`98`	`super(GitHubSession,self).__init__()`
`99`	`99`	`self.default_connect_timeout=default_connect_timeout`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,8 @@ def test_default_timeout(self, request_mock):`
`40`	`40`	`r=s.get("http://example.com")`
`41`	`41`	`assertrisresponse`
`42`	`42`	`request_mock.assert_called_once_with(`
`43`		`-"GET","http://example.com",allow_redirects=True,timeout=(4,1)`
	`43`	`+"GET","http://example.com",allow_redirects=True,`
	`44`	`+timeout=(4,10)`
`44`	`45`	`)`
`45`	`46`
`46`	`47`	`@mock.patch.object(requests.Session,"request")`
`@@ -148,7 +149,8 @@ def test_request_ignores_responses_that_do_not_require_2fa(`
`148`	`149`	`r=s.get("http://example.com")`
`149`	`150`	`assertrisresponse`
`150`	`151`	`request_mock.assert_called_once_with(`
`151`		`-"GET","http://example.com",allow_redirects=True,timeout=(4,1)`
	`152`	`+"GET","http://example.com",allow_redirects=True,`
	`153`	`+timeout=(4,10)`
`152`	`154`	`)`
`153`	`155`
`154`	`156`	`@mock.patch.object(requests.Session,"request")`

Comments

(0)