Commitc2bdf55

committed

Increase default read timeout to 10 seconds

The read timeout is the time until Github starts the response to anhttp request. The current default of one second can be too short for alocal maybe slower Github Enterprise. Instead change it to 10s asgithub suggests also in its best practices for request from Github tointegrations [1].[1]https://developer.github.com/v3/guides/best-practices-for-integrators/#favor-asynchronous-work-over-synchronous

1 parent5deccee commitc2bdf55Copy full SHA for c2bdf55

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ class GitHubSession(requests.Session):`
`93`	`93`	`"two_factor_auth_cb",`
`94`	`94`	`]`
`95`	`95`
`96`		`-def__init__(self,default_connect_timeout=4,default_read_timeout=1):`
	`96`	`+def__init__(self,default_connect_timeout=4,default_read_timeout=10):`
`97`	`97`	`"""Slightly modify how we initialize our session."""`
`98`	`98`	`super(GitHubSession,self).__init__()`
`99`	`99`	`self.default_connect_timeout=default_connect_timeout`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ def test_default_timeout(self, request_mock):`
`41`	`41`	`assertrisresponse`
`42`	`42`	`request_mock.assert_called_once_with(`
`43`	`43`	`"GET","http://example.com",allow_redirects=True,`
`44`		`-timeout=(4,1)`
	`44`	`+timeout=(4,10)`
`45`	`45`	`)`
`46`	`46`
`47`	`47`	`@mock.patch.object(requests.Session,'request')`
`@@ -149,7 +149,7 @@ def test_request_ignores_responses_that_do_not_require_2fa(`
`149`	`149`	`assertrisresponse`
`150`	`150`	`request_mock.assert_called_once_with(`
`151`	`151`	`"GET","http://example.com",allow_redirects=True,`
`152`		`-timeout=(4,1)`
	`152`	`+timeout=(4,10)`
`153`	`153`	`)`
`154`	`154`
`155`	`155`	`@mock.patch.object(requests.Session,"request")`

Comments

(0)