Commitac605fd

committed

index setter was leaking memory

1 parenta674658 commitac605fdCopy full SHA for ac605fd

File tree

-10

lines changed

-10

lines changed

Lines changed: 2 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -497,14 +497,8 @@ static int mp_ass_subscript_impl(BorrowedReference ob, BorrowedReference idx, Bo`
`497`	`497`	`// Add value to argument list`
`498`	`498`	`Runtime.PyTuple_SetItem(real.Borrow(), i, v);`
`499`	`499`
`500`		`- cls.indexer.SetItem(ob, real.Borrow());`
`501`		`-`
`502`		`- if (Exceptions.ErrorOccurred())`
`503`		`- {`
`504`		`- return -1;`
`505`		`- }`
`506`		`-`
`507`		`- return 0;`
	`500`	`+ using var result = cls.indexer.SetItem(ob, real.Borrow());`
	`501`	`+ return result.IsNull() ? -1 : 0;`
`508`	`502`	`}`
`509`	`503`
`510`	`504`	`static NewReference tp_call_impl(BorrowedReference ob, BorrowedReference args, BorrowedReference kw)`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,9 @@ internal NewReference GetItem(BorrowedReference inst, BorrowedReference args)`
`50`	`50`	`}`
`51`	`51`
`52`	`52`
`53`		`- internalvoid SetItem(BorrowedReference inst, BorrowedReference args)`
	`53`	`+ internalNewReference SetItem(BorrowedReference inst, BorrowedReference args)`
`54`	`54`	`{`
`55`		`- SetterBinder.Invoke(inst, args, null);`
	`55`	`+returnSetterBinder.Invoke(inst, args, null);`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`internal bool NeedsDefaultArgs(BorrowedReference args)`

Comments

(0)