- Notifications
You must be signed in to change notification settings - Fork262
feat(gha)!: use composite action for semantic release (#692)#741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
bernardcooke53 commentedOct 24, 2023
@zckv I have moved the changes from#692 over here. I'm thinking I want to add the following to this PR (based off of the breakage in the previous one):
Will make PRs against this branch for each of those, obviously no obligation but if you still want to work on the change would you mind doing the same please? That way it can all be merged at once 🙏 |
Later versions revertedpython-semantic-release/python-semantic-release#692which breaks builds on Python projects requiring a newer interpreterthan 3.10, which their container uses.Should be fine to update afterpython-semantic-release/python-semantic-release#741is merged again.Signed-off-by: Felix Kaechele <felix@kaechele.ca>
eikowagenknecht commentedJan 3, 2024
Would really love to see this PR go through because without it, projects that use a newer Python than 3.10 can't use the action at all. Pinning to 8.3.0 for now as well. |
9f8c42c toc5b6e58CompareResolves:#692Co-authored-by: Bernard Cooke <bernard-cooke@hotmail.com>
c5b6e58 toa5bf98eComparecodejedi365 commentedMay 6, 2024
@eikowagenknecht, although this composite action has not been merged yet.#914 has and it bumped the Docker action up to Python:3.12-bookworm as the base environment which will allow building of projects that use a minimum version of |
zckv commentedMay 6, 2024
Hello 👋 Wouldn't it be simpler to create a separate action repository ? This solution would avoid a "breaking" change on this project for something that is not related to the PSR python code. |
codejedi365 commentedMay 6, 2024
No, I don't believe so. It sounds nice up front but we would then have to keep both projects in sync. This action change would still be a breaking change which would then cause a version number drift of the version numbers of the project which likely confuses the configurations used and the users. This may not matter as the proper version is a set dependency in the action. I plan to wrap it in with the next breaking change for the project. The release will have a full migration instructions and such with it. Maybe at the breaking change it's moved to another repository which doesn't change all that much besides the version it points to upon this repository update. |
eikowagenknecht commentedMay 16, 2024
Thanks, working fine for 3.12 now. |
It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR? |
codejedi365 commentedJul 20, 2024
No update at this time however it looks like we will have a number of changes for Significant migration docs will be needed and any additional changes this PR didn't have completed yet. |
It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR? |
codejedi365 commentedSep 20, 2024
Haven't gotten back around to reviewing and integrating this yet for v10 |
It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR? |
codejedi365 commentedNov 20, 2024
Haven't had time to get back to this. Likely will be delayed until v11. |
It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR? |
codejedi365 commentedApr 19, 2025
Still in backlog |
It has been 60 days since the last update on this confirmed PR. @python-semantic-release/team can you provide an update on the status of this PR? |
No description provided.