- Notifications
You must be signed in to change notification settings - Fork262
fix(mypy): resolve compatibility issues with mypy 1.17.0#1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge2 commits intodependabot/pip/mypy-1.17.0Choose a base branch
base:dependabot/pip/mypy-1.17.0
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Update python_version from 3.8 to 3.9 (required by mypy 1.17.0)- Disable strict TypedDict checking for tests module- Add disable_error_code for test-specific type issues: - misc: TypedDict ambiguity in parameterized fixtures - arg-type: Argument type mismatches in test fixtures - typeddict-item: TypedDict item mismatches in test data - typeddict-unknown-key: Extra keys in test TypedDicts - list-item: List item type mismatches in test data - index: Indexing issues with Optional types after guardsThese changes allow tests to continue using flexible parameterizationpatterns while maintaining strict type checking for production code.Co-authored-by: codejedi365 <17354856+codejedi365@users.noreply.github.com>
CopilotAI changed the title[WIP] Fix mypy errors and disable problematic rulefix(mypy): resolve compatibility issues with mypy 1.17.0Nov 2, 2025
Copilot finished work on behalf ofcodejedi365November 2, 2025 17:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Mypy 1.17.0 dropped Python 3.8 support and introduced stricter TypedDict checking that conflicts with test fixture parameterization patterns.
Changes
Bumped
python_versionfrom 3.8 to 3.9 in mypy config (minimum version required by mypy 1.17.0)Disabled strict TypedDict checking for test modules by adding
disable_error_codefor:misc,arg-type,typeddict-item,typeddict-unknown-key,list-item: TypedDict inference in parameterized fixturesindex: Optional type narrowing after guardsImpact
Production code (
src/) maintains full strict type checking with zero errors. Test modules can continue using flexible parameterization patterns that mypy 1.17.0's stricter rules would otherwise reject. The 152 remainingimport-not-founderrors for test dependencies (pytest, freezegun, etc.) are expected and acceptable.Original prompt
✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.