Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork68
Fix tox so that it can run#408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The following changes are introduced:* Update the list of Python versions to test (3.9+)* Remove the now-unused `default` and `simplejson` factors* Switch to Poetry for dependency installation* Switch to running pytest to execute the test suite
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #408 +/- ##======================================= Coverage 92.09% 92.09% ======================================= Files 24 24 Lines 759 759 Branches 80 80 ======================================= Hits 699 699 Misses 42 42 Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rebased on |
@p1c2u I hope you're doing well! I wanted to ping you and ask if you could review some of these open PRs? |
Uh oh!
There was an error while loading.Please reload this page.
This PR introduces the following changes:
It updates the tox config so that it can run.
The
setup.pyfile is gone, as are therequirements.txtfiles. Poetry is invoked to install the dependencies now.It updates the list of Python versions to run the test suite against.
It removes the now-unused
defaultandsimplejsonfactorsTaken together, these changes allow developers to run the test suite locally before submitting PRs to the project.