Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: convert to using relative imports#1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
JohnVillalovos wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromjlvillal/relative_imports

Conversation

@JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedDec 5, 2021•
edited
Loading

First commit renamesgitlab/__version__.py togitlab.version.py to minimize confusion.

Switch to using relative imports to ensure that we are importing from
within our library.

Also use the form:
from foo import bar as bar
When we want to signify that we want the import to be re-exported.

https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport

@codecov-commenter
Copy link

codecov-commenter commentedDec 5, 2021•
edited by codecovbot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.03%. Comparing base (c6d7e9a) to head (6b3e7c0).
⚠️ Report is 1239 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #1728   +/-   ##=======================================  Coverage   92.02%   92.03%           =======================================  Files          76       76             Lines        4790     4793    +3     =======================================+ Hits         4408     4411    +3  Misses        382      382
FlagCoverage Δ
cli_func_v481.38% <96.66%> (+0.01%)⬆️
py_func_v480.24% <86.29%> (+0.03%)⬆️
unit83.18% <93.70%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
gitlab/__init__.py100.00% <100.00%> (ø)
gitlab/__main__.py100.00% <100.00%> (ø)
gitlab/base.py90.22% <100.00%> (ø)
gitlab/cli.py98.40% <100.00%> (+0.03%)⬆️
gitlab/client.py90.51% <100.00%> (-0.05%)⬇️
gitlab/config.py94.44% <100.00%> (ø)
gitlab/const.py100.00% <100.00%> (ø)
gitlab/mixins.py91.52% <100.00%> (-0.03%)⬇️
gitlab/v4/cli.py81.25% <100.00%> (-0.14%)⬇️
gitlab/v4/objects/access_requests.py100.00% <100.00%> (ø)
... and61 more
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohnVillalovosJohnVillalovos marked this pull request as draftDecember 5, 2021 20:05
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewDecember 5, 2021 20:12
nejch

This comment was marked as outdated.

@JohnVillalovos
Copy link
MemberAuthor

Note834677e is only a rebase with no functional changes. Had conflicts after another PR merged. Will work on fixing things in regards to comments later on today most likely.

@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/relative_imports branch 6 times, most recently fromc2dca37 to9afb42fCompareDecember 16, 2021 01:25
@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/relative_imports branch 2 times, most recently from7da5ac0 toc873c92CompareDecember 24, 2021 04:46
It was confusing having __version__.py as we were importing the__version__ variable from __version__.py into the top-level namespacewhile also having __version__.py. So depending where we were in theimport chain __version__ could refer to the module __version__.py orit could refer to the variable __version__
Switch to using relative imports to ensure that we are importing fromwithin our library.Also use the form:  from foo import bar as barWhen we want to signify that we want the import to be re-exported.https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport
@JohnVillalovosJohnVillalovos marked this pull request as draftFebruary 12, 2022 16:53
@github-actions
Copy link

This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days.

@github-actionsgithub-actionsbot added stale and removed stale labelsJul 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchnejch requested changes

Copilot code reviewCopilotAwaiting requested review from CopilotCopilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp