Commitee143c9

authored and

committed

chore: add basic typing to functional tests

1 parent50731c1 commitee143c9Copy full SHA for ee143c9

File tree

+11

-7

lines changed

+11

-7

lines changed

Lines changed: 1 addition & 1 deletion

Lines changed: 1 addition & 0 deletions

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ def gitlab_version(gl) -> GitlabVersion:`
`37`	`37`
`38`	`38`
`39`	`39`	`@pytest.fixture(scope="session")`
`40`		`-deffixture_dir(test_dir)->pathlib.Path:`
	`40`	`+deffixture_dir(test_dir:pathlib.Path)->pathlib.Path:`
`41`	`41`	`returntest_dir/"functional"/"fixtures"`
`42`	`42`
`43`	`43`
`@@ -56,7 +56,8 @@ def gitlab_container_name() -> str:`
`56`	`56`
`57`	`57`	`@pytest.fixture(scope="session")`
`58`	`58`	`defgitlab_docker_port(docker_services,gitlab_service_name:str)->int:`
`59`		`-returndocker_services.port_for(service=gitlab_service_name,container_port=80)`
	`59`	`+port:int=docker_services.port_for(gitlab_service_name,container_port=80)`
	`60`	`+returnport`
`60`	`61`
`61`	`62`
`62`	`63`	`@pytest.fixture(scope="session")`
`@@ -114,7 +115,7 @@ def reset_gitlab(gl: gitlab.Gitlab) -> None:`
`114`	`115`	`helpers.safe_delete(user,hard_delete=True)`
`115`	`116`
`116`	`117`
`117`		`-defset_token(container,fixture_dir):`
	`118`	`+defset_token(container:str,fixture_dir:pathlib.Path)->str:`
`118`	`119`	`logging.info("Creating API token.")`
`119`	`120`	`set_token_rb=fixture_dir/"set_token.rb"`
`120`	`121`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`importlogging`
`2`	`2`	`importtime`
`3`		`-fromtypingimportOptional`
	`3`	`+fromtypingimportOptional,TYPE_CHECKING`
`4`	`4`
`5`	`5`	`importpytest`
`6`	`6`
`@@ -19,8 +19,10 @@ def get_gitlab_plan(gl: gitlab.Gitlab) -> Optional[str]:`
`19`	`19`	`license=gl.get_license()`
`20`	`20`	`exceptgitlab.exceptions.GitlabLicenseError:`
`21`	`21`	`# Without a license we assume only Free features are available`
`22`		`-return`
	`22`	`+returnNone`
`23`	`23`
	`24`	`+ifTYPE_CHECKING:`
	`25`	`+assertisinstance(license["plan"],str)`
`24`	`26`	`returnlicense["plan"]`
`25`	`27`
`26`	`28`
`@@ -34,7 +36,7 @@ def safe_delete(`
`34`	`36`	`manager=object.manager`
`35`	`37`	`forindexinrange(MAX_ITERATIONS):`
`36`	`38`	`try:`
`37`		`-object=manager.get(object.get_id())`
	`39`	`+object=manager.get(object.get_id())# type: ignore[attr-defined]`
`38`	`40`	`exceptgitlab.exceptions.GitlabGetError:`
`39`	`41`	`return`
`40`	`42`

Comments

(0)