Commiteb54adf

authored

Merge pull request#2333 from python-gitlab/jlvillal/remove_approvers_endpoint

fix: remove `project.approvals.set_approvals()` method

2 parentsc676b43 +f0c02a5 commiteb54adfCopy full SHA for eb54adf

File tree

-37

lines changed

-37

lines changed

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,6 @@ Change project-level or MR-level MR approvals settings::`
`63`	`63`	`mr_mras.approvals_required = 1`
`64`	`64`	`mr_mras.save()`
`65`	`65`
`66`		`-Change project-level MR allowed approvers::`
`67`		`-`
`68`		`- project.approvals.set_approvers(approver_ids=[105],`
`69`		`- approver_group_ids=[653, 654])`
`70`		`-`
`71`	`66`	`Create a new MR-level approval rule or change an existing MR-level approval rule::`
`72`	`67`
`73`	`68`	`mr.approvals.set_approvers(approvals_required = 1, approver_ids=[105],`

Lines changed: 0 additions & 32 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,38 +50,6 @@ class ProjectApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTManager):`
`50`	`50`	`defget(self,**kwargs:Any)->ProjectApproval:`
`51`	`51`	`returncast(ProjectApproval,super().get(**kwargs))`
`52`	`52`
`53`		`-@exc.on_http_error(exc.GitlabUpdateError)`
`54`		`-defset_approvers(`
`55`		`-self,`
`56`		`-approver_ids:Optional[List[int]]=None,`
`57`		`-approver_group_ids:Optional[List[int]]=None,`
`58`		`-**kwargs:Any,`
`59`		`- )->Dict[str,Any]:`
`60`		`-"""Change project-level allowed approvers and approver groups.`
`61`		`-`
`62`		`- Args:`
`63`		`- approver_ids: User IDs that can approve MRs`
`64`		`- approver_group_ids: Group IDs whose members can approve MRs`
`65`		`-`
`66`		`- Raises:`
`67`		`- GitlabAuthenticationError: If authentication is not correct`
`68`		`- GitlabUpdateError: If the server failed to perform the request`
`69`		`-`
`70`		`- Returns:`
`71`		`- A dict value of the result`
`72`		`- """`
`73`		`-approver_ids=approver_idsor []`
`74`		`-approver_group_ids=approver_group_idsor []`
`75`		`-`
`76`		`-ifTYPE_CHECKING:`
`77`		`-assertself._parentisnotNone`
`78`		`-path=f"/projects/{self._parent.encoded_id}/approvers"`
`79`		`-data= {"approver_ids":approver_ids,"approver_group_ids":approver_group_ids}`
`80`		`-result=self.gitlab.http_put(path,post_data=data,**kwargs)`
`81`		`-ifTYPE_CHECKING:`
`82`		`-assertisinstance(result,dict)`
`83`		`-returnresult`
`84`		`-`
`85`	`53`
`86`	`54`	`classProjectApprovalRule(SaveMixin,ObjectDeleteMixin,RESTObject):`
`87`	`55`	`_id_attr="id"`

Lines changed: 1 addition & 0 deletions

Comments

(0)