Commite15349c

authored and

committed

fix(client): support empty 204 responses in http_patch

1 parentff45124 commite15349cCopy full SHA for e15349c

File tree

+18

-0

lines changed

+18

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1083,6 +1083,8 @@ def http_patch(`
`1083`	`1083`	`raw=raw,`
`1084`	`1084`	`**kwargs,`
`1085`	`1085`	`)`
	`1086`	`+ifresult.status_codeingitlab.const.NO_JSON_RESPONSE_CODES:`
	`1087`	`+returnresult`
`1086`	`1088`	`try:`
`1087`	`1089`	`json_result=result.json()`
`1088`	`1090`	`ifTYPE_CHECKING:`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ class SearchScope(GitlabEnum):`
`95`	`95`
`96`	`96`	`USER_AGENT:str=f"{__title__}/{__version__}"`
`97`	`97`
	`98`	`+NO_JSON_RESPONSE_CODES= [204]`
`98`	`99`	`RETRYABLE_TRANSIENT_ERROR_CODES= [500,502,503,504]+list(range(520,531))`
`99`	`100`
`100`	`101`	`__all__= [`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -800,6 +800,21 @@ def test_patch_request(gl):`
`800`	`800`	`assertresponses.assert_call_count(url,1)isTrue`
`801`	`801`
`802`	`802`
	`803`	`+@responses.activate`
	`804`	`+deftest_patch_request_204(gl):`
	`805`	`+url="http://localhost/api/v4/projects"`
	`806`	`+responses.add(`
	`807`	`+method=responses.PATCH,`
	`808`	`+url=url,`
	`809`	`+status=204,`
	`810`	`+match=helpers.MATCH_EMPTY_QUERY_PARAMS,`
	`811`	`+ )`
	`812`	`+`
	`813`	`+result=gl.http_patch("/projects")`
	`814`	`+assertisinstance(result,requests.Response)`
	`815`	`+assertresponses.assert_call_count(url,1)isTrue`
	`816`	`+`
	`817`	`+`
`803`	`818`	`@responses.activate`
`804`	`819`	`deftest_patch_request_404(gl):`
`805`	`820`	`url="http://localhost/api/v4/not_there"`

Comments

(0)