Commitd900910

authored and

committed

feat(api): support project remote mirror deletion

1 parent0d49164 commitd900910Copy full SHA for d900910

File tree

+22

-2

lines changed

docs/gl_objects
- remote_mirrors.rst
gitlab/v4/objects
- projects.py
tests
- functional/api
  - test_projects.py
- unit/objects
  - test_remote_mirrors.py

+22

-2

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,3 +32,7 @@ Update an existing remote mirror's attributes::`
`32`	`32`	`mirror.enabled = False`
`33`	`33`	`mirror.only_protected_branches = True`
`34`	`34`	`mirror.save()`
	`35`	`+`
	`36`	`+Delete an existing remote mirror::`
	`37`	`+`
	`38`	`+ mirror.delete()`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`fromgitlab.mixinsimport (`
`24`	`24`	`CreateMixin,`
`25`	`25`	`CRUDMixin,`
	`26`	`+DeleteMixin,`
`26`	`27`	`GetWithoutIdMixin,`
`27`	`28`	`ListMixin,`
`28`	`29`	`ObjectDeleteMixin,`
`@@ -1199,11 +1200,13 @@ def create(`
`1199`	`1200`	`returncast(ProjectFork,CreateMixin.create(self,data,path=path,**kwargs))`
`1200`	`1201`
`1201`	`1202`
`1202`		`-classProjectRemoteMirror(SaveMixin,RESTObject):`
	`1203`	`+classProjectRemoteMirror(ObjectDeleteMixin,SaveMixin,RESTObject):`
`1203`	`1204`	`pass`
`1204`	`1205`
`1205`	`1206`
`1206`		`-classProjectRemoteMirrorManager(ListMixin,CreateMixin,UpdateMixin,RESTManager):`
	`1207`	`+classProjectRemoteMirrorManager(`
	`1208`	`+ListMixin,CreateMixin,UpdateMixin,DeleteMixin,RESTManager`
	`1209`	`+):`
`1207`	`1210`	`_path="/projects/{project_id}/remote_mirrors"`
`1208`	`1211`	`_obj_cls=ProjectRemoteMirror`
`1209`	`1212`	`_from_parent_attrs= {"project_id":"id"}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -282,6 +282,8 @@ def test_project_remote_mirrors(project):`
`282`	`282`	`assertmirror.url==mirror_url`
`283`	`283`	`assertmirror.enabledisTrue`
`284`	`284`
	`285`	`+mirror.delete()`
	`286`	`+`
`285`	`287`
`286`	`288`	`deftest_project_services(project):`
`287`	`289`	`# Use 'update' to create a service as we don't have a 'create' method and`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,12 @@ def resp_remote_mirrors():`
`48`	`48`	`content_type="application/json",`
`49`	`49`	`status=200,`
`50`	`50`	`)`
	`51`	`+`
	`52`	`+rsps.add(`
	`53`	`+method=responses.DELETE,`
	`54`	`+url="http://localhost/api/v4/projects/1/remote_mirrors/1",`
	`55`	`+status=204,`
	`56`	`+ )`
`51`	`57`	`yieldrsps`
`52`	`58`
`53`	`59`
`@@ -70,3 +76,8 @@ def test_update_project_remote_mirror(project, resp_remote_mirrors):`
`70`	`76`	`mirror.save()`
`71`	`77`	`assertmirror.update_status=="finished"`
`72`	`78`	`assertmirror.only_protected_branches`
	`79`	`+`
	`80`	`+`
	`81`	`+deftest_delete_project_remote_mirror(project,resp_remote_mirrors):`
	`82`	`+mirror=project.remote_mirrors.create({"url":"https://example.com"})`
	`83`	`+mirror.delete()`

Comments

(0)