Commitd652133

authored and

committed

refactor: do not recommend plain gitlab.const constants

1 parentf185b17 commitd652133Copy full SHA for d652133

File tree

+10

-6

lines changed

+10

-6

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -43,9 +43,9 @@ def __getattr__(name: str) -> Any:`
`43`	`43`	`ifnameingitlab.const._DEPRECATED:`
`44`	`44`	`_utils.warn(`
`45`	`45`	`message=(`
`46`		`-f"\nDirect access to 'gitlab.{name}' is deprecated and will be "`
`47`		`-f"removed in a future major python-gitlab release. Please "`
`48`		`-f"use'gitlab.const.{name}' instead."`
	`46`	`+f"\nDirect access toconstants as'gitlab.{name}' is deprecated and "`
	`47`	`+f"will beremoved in a future major python-gitlab release. Please "`
	`48`	`+f"see the usage of constants in the'gitlab.const' module instead."`
`49`	`49`	`),`
`50`	`50`	`category=DeprecationWarning,`
`51`	`51`	`)`

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,10 @@`
`56`	`56`	`]`
`57`	`57`
`58`	`58`
	`59`	`+classGitlabEnum(str,Enum):`
	`60`	`+"""An enum mixed in with str to make it JSON-serializable."""`
	`61`	`+`
	`62`	`+`
`59`	`63`	`# https://gitlab.com/gitlab-org/gitlab/-/blob/e97357824bedf007e75f8782259fe07435b64fbb/lib/gitlab/access.rb#L12-18`
`60`	`64`	`classAccessLevel(IntEnum):`
`61`	`65`	`NO_ACCESS:int=0`
`@@ -69,13 +73,13 @@ class AccessLevel(IntEnum):`
`69`	`73`
`70`	`74`
`71`	`75`	`# https://gitlab.com/gitlab-org/gitlab/-/blob/e97357824bedf007e75f8782259fe07435b64fbb/lib/gitlab/visibility_level.rb#L23-25`
`72`		`-classVisibility(Enum):`
	`76`	`+classVisibility(GitlabEnum):`
`73`	`77`	`PRIVATE:str="private"`
`74`	`78`	`INTERNAL:str="internal"`
`75`	`79`	`PUBLIC:str="public"`
`76`	`80`
`77`	`81`
`78`		`-classNotificationLevel(Enum):`
	`82`	`+classNotificationLevel(GitlabEnum):`
`79`	`83`	`DISABLED:str="disabled"`
`80`	`84`	`PARTICIPATING:str="participating"`
`81`	`85`	`WATCH:str="watch"`
`@@ -85,7 +89,7 @@ class NotificationLevel(Enum):`
`85`	`89`
`86`	`90`
`87`	`91`	`# https://gitlab.com/gitlab-org/gitlab/-/blob/e97357824bedf007e75f8782259fe07435b64fbb/app/views/search/_category.html.haml#L10-37`
`88`		`-classSearchScope(Enum):`
	`92`	`+classSearchScope(GitlabEnum):`
`89`	`93`	`# all scopes (global, group and project)`
`90`	`94`	`PROJECTS:str="projects"`
`91`	`95`	`ISSUES:str="issues"`

Comments

(0)