Commitd0b0811

committed

chore: enable pylint check: "no-else-return"

Enable the pylint check "no-else-return" and fix the errors detected.

1 parentd6870a9 commitd0b0811Copy full SHA for d0b0811

File tree

-9

lines changed

-9

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -556,8 +556,7 @@ def _build_url(self, path: str) -> str:`
`556`	`556`	`"""`
`557`	`557`	`ifpath.startswith("http://")orpath.startswith("https://"):`
`558`	`558`	`returnpath`
`559`		`-else:`
`560`		`-returnf"{self._url}{path}"`
	`559`	`+returnf"{self._url}{path}"`
`561`	`560`
`562`	`561`	`def_check_redirects(self,result:requests.Response)->None:`
`563`	`562`	`# Check the requests history to detect 301/302 redirections.`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,7 @@ def __init__(`
`47`	`47`	`def__str__(self)->str:`
`48`	`48`	`ifself.response_codeisnotNone:`
`49`	`49`	`returnf"{self.response_code}:{self.error_message}"`
`50`		`-else:`
`51`		`-returnf"{self.error_message}"`
	`50`	`+returnf"{self.error_message}"`
`52`	`51`
`53`	`52`
`54`	`53`	`classGitlabAuthenticationError(GitlabError):`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -231,8 +231,7 @@ def list(self, **kwargs: Any) -> Union[base.RESTObjectList, List[base.RESTObject`
`231`	`231`	`obj=self.gitlab.http_list(path,**data)`
`232`	`232`	`ifisinstance(obj,list):`
`233`	`233`	`return [self._obj_cls(self,item,created_from_list=True)foriteminobj]`
`234`		`-else:`
`235`		`-returnbase.RESTObjectList(self,self._obj_cls,obj)`
	`234`	`+returnbase.RESTObjectList(self,self._obj_cls,obj)`
`236`	`235`
`237`	`236`
`238`	`237`	`classRetrieveMixin(ListMixin,GetMixin):`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,5 +49,4 @@ def list(self, **kwargs: Any) -> Union[List[LDAPGroup], RESTObjectList]:`
`49`	`49`	`obj=self.gitlab.http_list(path,**data)`
`50`	`50`	`ifisinstance(obj,list):`
`51`	`51`	`return [self._obj_cls(self,item)foriteminobj]`
`52`		`-else:`
`53`		`-returnRESTObjectList(self,self._obj_cls,obj)`
	`52`	`+returnRESTObjectList(self,self._obj_cls,obj)`

Lines changed: 0 additions & 1 deletion

Comments

(0)