Commitac46c1c

authored and

committed

fix(config): raise error when gitlab id provided but no config file found

1 parent789ef81 commitac46c1cCopy full SHA for ac46c1c

File tree

+11

-0

lines changed

+11

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,11 @@ def __init__(`
`128`	`128`	`ifself._files:`
`129`	`129`	`self._parse_config()`
`130`	`130`
	`131`	`+ifself.gitlab_idandnotself._files:`
	`132`	`+raiseGitlabConfigMissingError(`
	`133`	`+f"A gitlab id was provided ({self.gitlab_id}) but no config file found"`
	`134`	`+ )`
	`135`	`+`
`131`	`136`	`def_parse_config(self)->None:`
`132`	`137`	`_config=configparser.ConfigParser()`
`133`	`138`	`_config.read(self._files)`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@`
`25`	`25`	`importresponses`
`26`	`26`
`27`	`27`	`importgitlab`
	`28`	`+fromgitlab.configimportGitlabConfigMissingError`
`28`	`29`	`fromtests.unitimporthelpers`
`29`	`30`
`30`	`31`	`localhost="http://localhost"`
`@@ -299,6 +300,11 @@ def test_gitlab_from_config(default_config):`
`299`	`300`	`gitlab.Gitlab.from_config("one", [config_path])`
`300`	`301`
`301`	`302`
	`303`	`+deftest_gitlab_from_config_without_files_raises():`
	`304`	`+withpytest.raises(GitlabConfigMissingError,match="non-existing"):`
	`305`	`+gitlab.Gitlab.from_config("non-existing")`
	`306`	`+`
	`307`	`+`
`302`	`308`	`deftest_gitlab_subclass_from_config(default_config):`
`303`	`309`	`classMyGitlab(gitlab.Gitlab):`
`304`	`310`	`pass`

Comments

(0)