Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit905781b

Browse files
lgatellierLéo GATELLIER
and
Léo GATELLIER
authored
fix(api): delete invalid 'project-runner get' command (#1628)
* fix(api): delete 'group-runner get' and 'group-runner delete' commandsCo-authored-by: Léo GATELLIER <git@leogatellier.fr>
1 parent4170dbe commit905781b

File tree

2 files changed

+7
-17
lines changed

2 files changed

+7
-17
lines changed

‎gitlab/v4/objects/runners.py‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
fromgitlabimporttypes
44
fromgitlab.baseimportRequiredOptional,RESTManager,RESTObject
55
fromgitlab.mixinsimport (
6+
CreateMixin,
67
CRUDMixin,
8+
DeleteMixin,
79
ListMixin,
8-
NoUpdateMixin,
910
ObjectDeleteMixin,
1011
SaveMixin,
1112
)
@@ -114,11 +115,11 @@ def verify(self, token, **kwargs):
114115
self.gitlab.http_post(path,post_data=post_data,**kwargs)
115116

116117

117-
classGroupRunner(ObjectDeleteMixin,RESTObject):
118+
classGroupRunner(RESTObject):
118119
pass
119120

120121

121-
classGroupRunnerManager(NoUpdateMixin,RESTManager):
122+
classGroupRunnerManager(ListMixin,RESTManager):
122123
_path="/groups/%(group_id)s/runners"
123124
_obj_cls=GroupRunner
124125
_from_parent_attrs= {"group_id":"id"}
@@ -131,7 +132,7 @@ class ProjectRunner(ObjectDeleteMixin, RESTObject):
131132
pass
132133

133134

134-
classProjectRunnerManager(NoUpdateMixin,RESTManager):
135+
classProjectRunnerManager(CreateMixin,DeleteMixin,ListMixin,RESTManager):
135136
_path="/projects/%(project_id)s/runners"
136137
_obj_cls=ProjectRunner
137138
_from_parent_attrs= {"project_id":"id"}

‎tests/unit/objects/test_runners.py‎

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def resp_runner_register():
143143
@pytest.fixture
144144
defresp_runner_enable():
145145
withresponses.RequestsMock()asrsps:
146-
pattern=re.compile(r".*?(projects|groups)/1/runners")
146+
pattern=re.compile(r".*?projects/1/runners")
147147
rsps.add(
148148
method=responses.POST,
149149
url=pattern,
@@ -176,7 +176,7 @@ def resp_runner_delete():
176176
@pytest.fixture
177177
defresp_runner_disable():
178178
withresponses.RequestsMock()asrsps:
179-
pattern=re.compile(r".*?/(groups|projects)/1/runners/6")
179+
pattern=re.compile(r".*?/projects/1/runners/6")
180180
rsps.add(
181181
method=responses.DELETE,
182182
url=pattern,
@@ -252,24 +252,13 @@ def test_disable_project_runner(gl: gitlab.Gitlab, resp_runner_disable):
252252
gl.projects.get(1,lazy=True).runners.delete(6)
253253

254254

255-
deftest_disable_group_runner(gl:gitlab.Gitlab,resp_runner_disable):
256-
gl.groups.get(1,lazy=True).runners.delete(6)
257-
258-
259255
deftest_enable_project_runner(gl:gitlab.Gitlab,resp_runner_enable):
260256
runner=gl.projects.get(1,lazy=True).runners.create({"runner_id":6})
261257
assertrunner.activeisTrue
262258
assertrunner.id==6
263259
assertrunner.name=="test-name"
264260

265261

266-
deftest_enable_group_runner(gl:gitlab.Gitlab,resp_runner_enable):
267-
runner=gl.groups.get(1,lazy=True).runners.create({"runner_id":6})
268-
assertrunner.activeisTrue
269-
assertrunner.id==6
270-
assertrunner.name=="test-name"
271-
272-
273262
deftest_verify_runner(gl:gitlab.Gitlab,resp_runner_verify):
274263
gl.runners.verify("token")
275264

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp