Commit5b81d7d

authored

Merge pull request#1412 from JohnVillalovos/jlvillal/optional_get_attrs

chore: make Get.*Mixin._optional_get_attrs always present

2 parents37af229 +3c1a0b3 commit5b81d7dCopy full SHA for 5b81d7d

File tree

-7

lines changed

-7

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ class GetMixin(_RestManagerBase):`
`75`	`75`	`_computed_path:Optional[str]`
`76`	`76`	`_from_parent_attrs:Dict[str,Any]`
`77`	`77`	`_obj_cls:Optional[Type[base.RESTObject]]`
	`78`	`+_optional_get_attrs:Tuple[str, ...]= ()`
`78`	`79`	`_parent:Optional[base.RESTObject]`
`79`	`80`	`_parent_attrs:Dict[str,Any]`
`80`	`81`	`_path:Optional[str]`
`@@ -119,6 +120,7 @@ class GetWithoutIdMixin(_RestManagerBase):`
`119`	`120`	`_computed_path:Optional[str]`
`120`	`121`	`_from_parent_attrs:Dict[str,Any]`
`121`	`122`	`_obj_cls:Optional[Type[base.RESTObject]]`
	`123`	`+_optional_get_attrs:Tuple[str, ...]= ()`
`122`	`124`	`_parent:Optional[base.RESTObject]`
`123`	`125`	`_parent_attrs:Dict[str,Any]`
`124`	`126`	`_path:Optional[str]`

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -165,13 +165,10 @@ def _populate_sub_parser_by_class(cls, sub_parser):`
`165`	`165`	`id_attr=cls._id_attr.replace("_","-")`
`166`	`166`	`sub_parser_action.add_argument("--%s"%id_attr,required=True)`
`167`	`167`
`168`		`-ifhasattr(mgr_cls,"_optional_get_attrs"):`
`169`		`- [`
`170`		`-sub_parser_action.add_argument(`
`171`		`-"--%s"%x.replace("_","-"),required=False`
`172`		`- )`
`173`		`-forxinmgr_cls._optional_get_attrs`
`174`		`- ]`
	`168`	`+forxinmgr_cls._optional_get_attrs:`
	`169`	`+sub_parser_action.add_argument(`
	`170`	`+"--%s"%x.replace("_","-"),required=False`
	`171`	`+ )`
`175`	`172`
`176`	`173`	`ifaction_name=="create":`
`177`	`174`	`forxinmgr_cls._create_attrs.required:`

Comments

(0)