Commit5583eaa

JohnVillalovos

and

nejch

authored

docs(api): fix incorrect docs for merge_request_approvals (#2094)

* docs(api): fix incorrect docs for merge_request_approvalsThe `set_approvers()` method is on the `ProjectApprovalManager` class.It is not part of the `ProjectApproval` class.The docs were previously showing to call `set_approvers` using a`ProjectApproval` instance, which would fail. Correct thedocumentation.This was pointed out by a question on the Gitter channel.Co-authored-by: Nejc Habjan <nejc.habjan@siemens.com>

1 parenta825844 commit5583eaaCopy full SHA for 5583eaa

File tree

1 file changed

-1

lines changed

docs/gl_objects
- merge_request_approvals.rst

1 file changed

-1

lines changed

`‎docs/gl_objects/merge_request_approvals.rst‎`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,10 @@ Change project-level or MR-level MR approvals settings::`
`58`	`58`	`p_mras.approvals_before_merge = 2`
`59`	`59`	`p_mras.save()`
`60`	`60`
`61`		`- mr_mras.set_approvers(approvals_required = 1)`
	`61`	`+ mr.approvals.set_approvers(approvals_required=1)`
	`62`	`+ # or`
	`63`	`+ mr_mras.approvals_required = 1`
	`64`	`+ mr_mras.save()`
`62`	`65`
`63`	`66`	`Change project-level MR allowed approvers::`
`64`	`67`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5583eaa

File tree

1 file changed

1 file changed

`‎docs/gl_objects/merge_request_approvals.rst‎`

0 commit comments