Commit48fc907

authored

Merge pull request#1336 from em-/fix/quote-everything

fix: handle tags like debian/2%2.6-21 as identifiers

2 parents63ecd2e +b4dac5c commit48fc907Copy full SHA for 48fc907

File tree

+11

-3

lines changed

+11

-3

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,10 @@ def test_clean_str_id():`
`27`	`27`	`dest="foo%23bar%2Fbaz%2F"`
`28`	`28`	`assertdest==utils.clean_str_id(src)`
`29`	`29`
	`30`	`+src="foo%bar/baz/"`
	`31`	`+dest="foo%25bar%2Fbaz%2F"`
	`32`	`+assertdest==utils.clean_str_id(src)`
	`33`	`+`
`30`	`34`
`31`	`35`	`deftest_sanitized_url():`
`32`	`36`	`src="http://localhost/foo/bar"`
`@@ -48,6 +52,10 @@ def test_sanitize_parameters_slash():`
`48`	`52`	`assert"foo%2Fbar"==utils.sanitize_parameters("foo/bar")`
`49`	`53`
`50`	`54`
	`55`	`+deftest_sanitize_parameters_slash_and_percent():`
	`56`	`+assert"foo%2Fbar%25quuz"==utils.sanitize_parameters("foo/bar%quuz")`
	`57`	`+`
	`58`	`+`
`51`	`59`	`deftest_sanitize_parameters_dict():`
`52`	`60`	`source= {"url":"foo/bar","id":1}`
`53`	`61`	`expected= {"url":"foo%2Fbar","id":1}`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`# along with this program. If not, see <http://www.gnu.org/licenses/>.`
`17`	`17`
`18`	`18`	`fromtypingimportAny,Callable,Dict,Optional`
`19`		`-fromurllib.parseimporturlparse`
	`19`	`+fromurllib.parseimportquote,urlparse`
`20`	`20`
`21`	`21`	`importrequests`
`22`	`22`
`@@ -57,14 +57,14 @@ def copy_dict(dest: Dict[str, Any], src: Dict[str, Any]) -> None:`
`57`	`57`
`58`	`58`
`59`	`59`	`defclean_str_id(id:str)->str:`
`60`		`-returnid.replace("/","%2F").replace("#","%23")`
	`60`	`+returnquote(id,safe="")`
`61`	`61`
`62`	`62`
`63`	`63`	`defsanitize_parameters(value):`
`64`	`64`	`ifisinstance(value,dict):`
`65`	`65`	`returndict((k,sanitize_parameters(v))fork,vinvalue.items())`
`66`	`66`	`ifisinstance(value,str):`
`67`		`-returnvalue.replace("/","%2F")`
	`67`	`+returnquote(value,safe="")`
`68`	`68`	`returnvalue`
`69`	`69`
`70`	`70`

Comments

(0)