Commit3fb4486

authored

Merge pull request#1862 from thomasgl-orange/cli-fix-timeout

fix(cli): make 'timeout', 'per_page' and 'page' type explicit

2 parents30117a3 +d493a5e commit3fb4486Copy full SHA for 3fb4486

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,7 @@ def _get_base_parser(add_help: bool = True) -> argparse.ArgumentParser:`
`181`	`181`	`"[env var: GITLAB_TIMEOUT]"`
`182`	`182`	`),`
`183`	`183`	`required=False,`
	`184`	`+type=int,`
`184`	`185`	`default=os.getenv("GITLAB_TIMEOUT"),`
`185`	`186`	`)`
`186`	`187`	`parser.add_argument(`
`@@ -196,6 +197,7 @@ def _get_base_parser(add_help: bool = True) -> argparse.ArgumentParser:`
`196`	`197`	`"[env var: GITLAB_PER_PAGE]"`
`197`	`198`	`),`
`198`	`199`	`required=False,`
	`200`	`+type=int,`
`199`	`201`	`default=os.getenv("GITLAB_PER_PAGE"),`
`200`	`202`	`)`
`201`	`203`	`parser.add_argument(`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,8 @@ def _populate_sub_parser_by_class(`
`218`	`218`	`f"--{x.replace('_','-')}",required=False`
`219`	`219`	`)`
`220`	`220`
`221`		`-sub_parser_action.add_argument("--page",required=False)`
`222`		`-sub_parser_action.add_argument("--per-page",required=False)`
	`221`	`+sub_parser_action.add_argument("--page",required=False,type=int)`
	`222`	`+sub_parser_action.add_argument("--per-page",required=False,type=int)`
`223`	`223`	`sub_parser_action.add_argument("--all",required=False,action="store_true")`
`224`	`224`
`225`	`225`	`ifaction_name=="delete":`

Comments

(0)