NotificationsYou must be signed in to change notification settings
Fork674
Star2.4k

Commit380f227

committed

chore: fix E741/E742 errors reported by flake8

Fixes to resolve errors for:https://www.flake8rules.com/rules/E741.html Do not use variables named 'I', 'O', or 'l' (E741)https://www.flake8rules.com/rules/E742.html Do not define classes named 'I', 'O', or 'l' (E742)

1 parentaf781c1 commit380f227Copy full SHA for 380f227

File tree

3 files changed

+20

-20

lines changed

gitlab/tests
- mixins
  - test_mixin_methods.py
  - test_object_mixins_attributes.py
- test_gitlab.py

3 files changed

+20

-20

lines changed

`‎gitlab/tests/mixins/test_mixin_methods.py‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ def resp_cont(url, request):`
`44`	`44`
`45`	`45`
`46`	`46`	`deftest_refresh_mixin(gl):`
`47`		`-classO(RefreshMixin,FakeObject):`
	`47`	`+classTestClass(RefreshMixin,FakeObject):`
`48`	`48`	`pass`
`49`	`49`
`50`	`50`	`@urlmatch(scheme="http",netloc="localhost",path="/api/v4/tests/42",method="get")`
`@@ -55,7 +55,7 @@ def resp_cont(url, request):`
`55`	`55`
`56`	`56`	`withHTTMock(resp_cont):`
`57`	`57`	`mgr=FakeManager(gl)`
`58`		`-obj=O(mgr, {"id":42})`
	`58`	`+obj=TestClass(mgr, {"id":42})`
`59`	`59`	`res=obj.refresh()`
`60`	`60`	`assertresisNone`
`61`	`61`	`assertobj.foo=="bar"`
`@@ -265,7 +265,7 @@ def test_save_mixin(gl):`
`265`	`265`	`classM(UpdateMixin,FakeManager):`
`266`	`266`	`pass`
`267`	`267`
`268`		`-classO(SaveMixin,base.RESTObject):`
	`268`	`+classTestClass(SaveMixin,base.RESTObject):`
`269`	`269`	`pass`
`270`	`270`
`271`	`271`	`@urlmatch(scheme="http",netloc="localhost",path="/api/v4/tests/42",method="put")`
`@@ -276,7 +276,7 @@ def resp_cont(url, request):`
`276`	`276`
`277`	`277`	`withHTTMock(resp_cont):`
`278`	`278`	`mgr=M(gl)`
`279`		`-obj=O(mgr, {"id":42,"foo":"bar"})`
	`279`	`+obj=TestClass(mgr, {"id":42,"foo":"bar"})`
`280`	`280`	`obj.foo="baz"`
`281`	`281`	`obj.save()`
`282`	`282`	`assertobj._attrs["foo"]=="baz"`

`‎gitlab/tests/mixins/test_object_mixins_attributes.py‎`

Lines changed: 12 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,35 +27,35 @@`
`27`	`27`
`28`	`28`
`29`	`29`	`deftest_access_request_mixin():`
`30`		`-classO(AccessRequestMixin):`
	`30`	`+classTestClass(AccessRequestMixin):`
`31`	`31`	`pass`
`32`	`32`
`33`		`-obj=O()`
	`33`	`+obj=TestClass()`
`34`	`34`	`asserthasattr(obj,"approve")`
`35`	`35`
`36`	`36`
`37`	`37`	`deftest_subscribable_mixin():`
`38`		`-classO(SubscribableMixin):`
	`38`	`+classTestClass(SubscribableMixin):`
`39`	`39`	`pass`
`40`	`40`
`41`		`-obj=O()`
	`41`	`+obj=TestClass()`
`42`	`42`	`asserthasattr(obj,"subscribe")`
`43`	`43`	`asserthasattr(obj,"unsubscribe")`
`44`	`44`
`45`	`45`
`46`	`46`	`deftest_todo_mixin():`
`47`		`-classO(TodoMixin):`
	`47`	`+classTestClass(TodoMixin):`
`48`	`48`	`pass`
`49`	`49`
`50`		`-obj=O()`
	`50`	`+obj=TestClass()`
`51`	`51`	`asserthasattr(obj,"todo")`
`52`	`52`
`53`	`53`
`54`	`54`	`deftest_time_tracking_mixin():`
`55`		`-classO(TimeTrackingMixin):`
	`55`	`+classTestClass(TimeTrackingMixin):`
`56`	`56`	`pass`
`57`	`57`
`58`		`-obj=O()`
	`58`	`+obj=TestClass()`
`59`	`59`	`asserthasattr(obj,"time_stats")`
`60`	`60`	`asserthasattr(obj,"time_estimate")`
`61`	`61`	`asserthasattr(obj,"reset_time_estimate")`
`@@ -64,16 +64,16 @@ class O(TimeTrackingMixin):`
`64`	`64`
`65`	`65`
`66`	`66`	`deftest_set_mixin():`
`67`		`-classO(SetMixin):`
	`67`	`+classTestClass(SetMixin):`
`68`	`68`	`pass`
`69`	`69`
`70`		`-obj=O()`
	`70`	`+obj=TestClass()`
`71`	`71`	`asserthasattr(obj,"set")`
`72`	`72`
`73`	`73`
`74`	`74`	`deftest_user_agent_detail_mixin():`
`75`		`-classO(UserAgentDetailMixin):`
	`75`	`+classTestClass(UserAgentDetailMixin):`
`76`	`76`	`pass`
`77`	`77`
`78`		`-obj=O()`
	`78`	`+obj=TestClass()`
`79`	`79`	`asserthasattr(obj,"user_agent_detail")`

`‎gitlab/tests/test_gitlab.py‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -86,10 +86,10 @@ def test_gitlab_build_list(gl):`
`86`	`86`	`assertobj.total==2`
`87`	`87`
`88`	`88`	`withHTTMock(resp_page_2):`
`89`		`-l=list(obj)`
`90`		`-assertlen(l)==2`
`91`		`-assertl[0]["a"]=="b"`
`92`		`-assertl[1]["c"]=="d"`
	`89`	`+test_list=list(obj)`
	`90`	`+assertlen(test_list)==2`
	`91`	`+asserttest_list[0]["a"]=="b"`
	`92`	`+asserttest_list[1]["c"]=="d"`
`93`	`93`
`94`	`94`
`95`	`95`	`@with_httmock(resp_page_1,resp_page_2)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit380f227

File tree

3 files changed

3 files changed

`‎gitlab/tests/mixins/test_mixin_methods.py‎`

`‎gitlab/tests/mixins/test_object_mixins_attributes.py‎`

`‎gitlab/tests/test_gitlab.py‎`

0 commit comments