NotificationsYou must be signed in to change notification settings
Fork675
Star2.4k

Commit2f37ccb

authored

Merge pull request#1733 from simonisateur/fix-package-file-delete

feat: package file delete on package file object

2 parents4945353 +124667b commit2f37ccbCopy full SHA for 2f37ccb

File tree

3 files changed

+36

-3

lines changed

docs/gl_objects
- packages.rst
gitlab/v4/objects
- packages.py
tests/unit/objects
- test_packages.py

3 files changed

+36

-3

lines changed

`‎docs/gl_objects/packages.rst‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ Delete a package file in a project::`
`93`	`93`
`94`	`94`	`package = project.packages.get(1)`
`95`	`95`	`file = package.package_files.list()[0]`
`96`		`-package.package_files.delete(file.id)`
	`96`	`+file.delete()`
`97`	`97`
`98`	`98`
`99`	`99`	`Generic Packages`

`‎gitlab/v4/objects/packages.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ def get(`
`173`	`173`	`returncast(ProjectPackage,super().get(id=id,lazy=lazy,**kwargs))`
`174`	`174`
`175`	`175`
`176`		`-classProjectPackageFile(RESTObject):`
	`176`	`+classProjectPackageFile(ObjectDeleteMixin,RESTObject):`
`177`	`177`	`pass`
`178`	`178`
`179`	`179`

`‎tests/unit/objects/test_packages.py‎`

Lines changed: 34 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,29 @@ def resp_delete_package_file(no_content):`
`168`	`168`	`yieldrsps`
`169`	`169`
`170`	`170`
	`171`	`+@pytest.fixture`
	`172`	`+defresp_delete_package_file_list(no_content):`
	`173`	`+withresponses.RequestsMock()asrsps:`
	`174`	`+rsps.add(`
	`175`	`+method=responses.GET,`
	`176`	`+url=re.compile(`
	`177`	`+r"http://localhost/api/v4/projects/1/packages/1/package_files"`
	`178`	`+ ),`
	`179`	`+json=package_file_content,`
	`180`	`+content_type="application/json",`
	`181`	`+status=200,`
	`182`	`+ )`
	`183`	`+forpkg_file_idinrange(25,28):`
	`184`	`+rsps.add(`
	`185`	`+method=responses.DELETE,`
	`186`	`+url=f"http://localhost/api/v4/projects/1/packages/1/package_files/{pkg_file_id}",`
	`187`	`+json=no_content,`
	`188`	`+content_type="application/json",`
	`189`	`+status=204,`
	`190`	`+ )`
	`191`	`+yieldrsps`
	`192`	`+`
	`193`	`+`
`171`	`194`	`@pytest.fixture`
`172`	`195`	`defresp_list_package_files():`
`173`	`196`	`withresponses.RequestsMock()asrsps:`
`@@ -242,11 +265,21 @@ def test_list_project_package_files(project, resp_list_package_files):`
`242`	`265`	`assertpackage_files[0].id==25`
`243`	`266`
`244`	`267`
`245`		`-deftest_delete_project_package_file(project,resp_delete_package_file):`
	`268`	`+deftest_delete_project_package_file_from_package_object(`
	`269`	`+project,resp_delete_package_file`
	`270`	`+):`
`246`	`271`	`package=project.packages.get(1,lazy=True)`
`247`	`272`	`package.package_files.delete(1)`
`248`	`273`
`249`	`274`
	`275`	`+deftest_delete_project_package_file_from_package_file_object(`
	`276`	`+project,resp_delete_package_file_list`
	`277`	`+):`
	`278`	`+package=project.packages.get(1,lazy=True)`
	`279`	`+forpackage_fileinpackage.package_files.list():`
	`280`	`+package_file.delete()`
	`281`	`+`
	`282`	`+`
`250`	`283`	`deftest_upload_generic_package(tmp_path,project,resp_upload_generic_package):`
`251`	`284`	`path=tmp_path/file_name`
`252`	`285`	`path.write_text(file_content)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2f37ccb

File tree

3 files changed

3 files changed

`‎docs/gl_objects/packages.rst‎`

`‎gitlab/v4/objects/packages.py‎`

`‎tests/unit/objects/test_packages.py‎`

0 commit comments