Commit2cbd674

ptalbert

authored and

nejch

committed

fix(api): use ID instead of name for GroupLabel & ProjectLabel _id_attr

_id_attr is used when comparing RESTObject objects. Labels will be seenas equal when they have the same name even if they are from differentgroups or projects.Instead, use the label's ID as the _id_attr so that comparisions willonly be equal if they truly represent the same gitlab label object.Signed-off-by: Patrick Talbert <ptalbert@redhat.com>

1 parentc378817 commit2cbd674Copy full SHA for 2cbd674

File tree

1 file changed

-2

lines changed

gitlab/v4/objects
- labels.py

1 file changed

-2

lines changed

`‎gitlab/v4/objects/labels.py‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,8 @@`
`23`	`23`
`24`	`24`
`25`	`25`	`classGroupLabel(SubscribableMixin,SaveMixin,ObjectDeleteMixin,RESTObject):`
`26`		`-_id_attr="name"`
	`26`	`+_id_attr="id"`
	`27`	`+_repr_attr="name"`
`27`	`28`	`manager:"GroupLabelManager"`
`28`	`29`
`29`	`30`	`# Update without ID, but we need an ID to get from list.`
`@@ -87,7 +88,8 @@ def update( # type: ignore`
`87`	`88`	`classProjectLabel(`
`88`	`89`	`PromoteMixin,SubscribableMixin,SaveMixin,ObjectDeleteMixin,RESTObject`
`89`	`90`	`):`
`90`		`-_id_attr="name"`
	`91`	`+_id_attr="id"`
	`92`	`+_repr_attr="name"`
`91`	`93`	`manager:"ProjectLabelManager"`
`92`	`94`
`93`	`95`	`# Update without ID, but we need an ID to get from list.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2cbd674

File tree

1 file changed

1 file changed

`‎gitlab/v4/objects/labels.py‎`

0 commit comments