Commit1ef7018

authored and

committed

fix(config): raise error when gitlab id provided but no config section found

1 parentac46c1c commit1ef7018Copy full SHA for 1ef7018

File tree

+12

-1

lines changed

+12

-1

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,12 @@ def _parse_config(self) -> None:`
`137`	`137`	`_config=configparser.ConfigParser()`
`138`	`138`	`_config.read(self._files)`
`139`	`139`
	`140`	`+ifself.gitlab_idandnot_config.has_section(self.gitlab_id):`
	`141`	`+raiseGitlabDataError(`
	`142`	`+f"A gitlab id was provided ({self.gitlab_id}) "`
	`143`	`+"but no config section found"`
	`144`	`+ )`
	`145`	`+`
`140`	`146`	`ifself.gitlab_idisNone:`
`141`	`147`	`try:`
`142`	`148`	`self.gitlab_id=_config.get("global","default")`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`importresponses`
`26`	`26`
`27`	`27`	`importgitlab`
`28`		`-fromgitlab.configimportGitlabConfigMissingError`
	`28`	`+fromgitlab.configimportGitlabConfigMissingError,GitlabDataError`
`29`	`29`	`fromtests.unitimporthelpers`
`30`	`30`
`31`	`31`	`localhost="http://localhost"`
`@@ -305,6 +305,11 @@ def test_gitlab_from_config_without_files_raises():`
`305`	`305`	`gitlab.Gitlab.from_config("non-existing")`
`306`	`306`
`307`	`307`
	`308`	`+deftest_gitlab_from_config_with_wrong_gitlab_id_raises(default_config):`
	`309`	`+withpytest.raises(GitlabDataError,match="non-existing"):`
	`310`	`+gitlab.Gitlab.from_config("non-existing", [default_config])`
	`311`	`+`
	`312`	`+`
`308`	`313`	`deftest_gitlab_subclass_from_config(default_config):`
`309`	`314`	`classMyGitlab(gitlab.Gitlab):`
`310`	`315`	`pass`

Comments

(0)