Commit097cf85

Moshe Zadka

committed

Inspired by Tim Peters' 1.14->1.15 checkin to asynchat

Quoting orignal message:'''Fix from the Madusa mailing list:http://groups.yahoo.com/group/medusa/message/333It's clear that Medusa should not be checking for an empty buffervia "buf is ''". The patch merely changes "is" to "==". However,there's a mystery here all the same: Python attempts to store nullstrings uniquely, so it's unclear why "buf is ''" ever returnedfalse when buf actually was empty. *Some* string operations producenon-unique null strings, e.g.'''

1 parentabbae5b commit097cf85Copy full SHA for 097cf85

File tree

1 file changed

-1

lines changed

Lib
- asynchat.py

1 file changed

-1

lines changed

`‎Lib/asynchat.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ def writable (self):`
`166`	`166`	`# return len(self.ac_out_buffer) or len(self.producer_fifo) or (not self.connected)`
`167`	`167`	`# this is about twice as fast, though not as clear.`
`168`	`168`	`returnnot (`
`169`		`-(self.ac_out_bufferis'')and`
	`169`	`+(self.ac_out_buffer=='')and`
`170`	`170`	`self.producer_fifo.is_empty()and`
`171`	`171`	`self.connected`
`172`	`172`	`)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit097cf85

File tree

1 file changed

1 file changed

`‎Lib/asynchat.py‎`

0 commit comments