Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add type annotations#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
basnijholt wants to merge21 commits intomainfrommypy
Closed

Add type annotations#244

basnijholt wants to merge21 commits intomainfrommypy

Conversation

@basnijholt
Copy link
Member

@basnijholtbasnijholt commentedDec 15, 2019•
edited
Loading

I have used MonkeyType when running the tests that automatically added the type hints.

Then I went over all the changes and fixed (or simplified) the things.

@basnijholtbasnijholtforce-pushed themypy branch 9 times, most recently fromcdf369d to54a6726CompareDecember 15, 2019 18:18
@basnijholtbasnijholt changed the titleWIP: Add type annotationsAdd type annotationsDec 15, 2019
@basnijholtbasnijholtforce-pushed themypy branch 3 times, most recently frome959e8c to91c1ebdCompareDecember 15, 2019 22:01
@basnijholt
Copy link
MemberAuthor

@akhmerov and@jbweston, I am done with this.

The only thing that has room for improvement, is the loss functions of theLearnerND. However, since we might deprecate that code, I didn't invest too much time.

@codecov-io
Copy link

codecov-io commentedDec 18, 2019•
edited
Loading

Codecov Report

Merging#244 intomaster willincrease coverage by0.22%.
The diff coverage is96.48%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #244      +/-   ##==========================================+ Coverage   79.52%   79.74%   +0.22%==========================================  Files          32       32                Lines        4401     4469      +68       Branches      810      810              ==========================================+ Hits         3500     3564      +64- Misses        776      778       +2- Partials      125      127       +2
Impacted FilesCoverage Δ
adaptive/_version.py48.14% <100%> (+0.48%)⬆️
adaptive/learner/skopt_learner.py59.7% <100%> (+1.23%)⬆️
adaptive/learner/learner1D.py91.89% <100%> (-0.44%)⬇️
adaptive/learner/learner2D.py78.49% <100%> (+0.1%)⬆️
adaptive/utils.py83.05% <100%> (+0.59%)⬆️
adaptive/learner/triangulation.py85.2% <100%> (+0.31%)⬆️
adaptive/learner/balancing_learner.py74.46% <100%> (+0.69%)⬆️
adaptive/learner/data_saver.py88.88% <100%> (+0.65%)⬆️
adaptive/learner/integrator_learner.py88.17% <100%> (+0.23%)⬆️
adaptive/learner/integrator_coeffs.py95.34% <100%> (+0.05%)⬆️
... and8 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatedfeb5ef...100f289. Read thecomment docs.

@basnijholtbasnijholtforce-pushed themypy branch 5 times, most recently from30cded3 to614f599CompareDecember 20, 2019 17:27
@jbwestonjbweston self-requested a reviewApril 28, 2020 20:00
@jbweston
Copy link
Contributor

I've put this on my review backlog

@basnijholt
Copy link
MemberAuthor

Closing.

This is superseded by#370,#371,#372,#373,#374,#375,#376,#377,#378, and#379.

@basnijholtbasnijholt deleted the mypy branchOctober 12, 2022 22:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jbwestonjbwestonAwaiting requested review from jbweston

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@basnijholt@codecov-io@jbweston
[8]ページ先頭
©2009-2025 Movatter.jp