- Notifications
You must be signed in to change notification settings - Fork62
run test_balancing_learner for all strategies#218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
basnijholt commentedSep 18, 2019
Something broke in between these two commits to However, when I reverse the exact changes fromca8b1d5 in that state of the repo, it is still broken. So seemingly it is not the code inside the |
basnijholt commentedSep 18, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
#!/usr/bin/env python3importsysfromfunctoolsimportpartialimportadaptivef=lambdax:x[0]learner=adaptive.BalancingLearner( [adaptive.LearnerND(f,bounds=[(-1,1), (-1,1)])],strategy="loss")try:# fails in masteradaptive.runner.simple(learner,goal=lambdal:l.learners[0].npoints>20)except:sys.exit(1)sys.exit(0) using the power of |
jbweston commentedOct 17, 2019
We should probably add the test, but we can probably wait until#220 is merged, because that will replace LearnerND anyway. |

Uh oh!
There was an error while loading.Please reload this page.
@python-adaptive/core this reveals a regression in the
LearnerND.Should we merge this already (without a fix)?
also: @JornHoofwijk