- Notifications
You must be signed in to change notification settings - Fork624
infra: format with ruff#2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
JacobCoffee commentedSep 12, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
there's about 7000 issues found with ruff lint. taking away docstring and missing type annotations its not so bad at around ~500 so working through some of those to see if its something we want to do (i do 🥹) |
ewdurbin commentedSep 12, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Zero opposition, but please can handle all concerns then rebase this down to one commit so we can do something likehttps://black.readthedocs.io/en/stable/guides/introducing_black_to_your_project.html#avoiding-ruining-git-blame |
"We're happy to announce the new way to file a contributor " | ||
"agreement: on the web at", | ||
self.entries[0]['summary'] | ||
"We're happy to announce the new way to file a contributor " "agreement: on the web at", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Turn on ISC to catch these:
"We're happy to announce the new way to file a contributor""agreement: on the web at", | |
"We're happy to announce the new way to file a contributor agreement: on the web at", |
https://docs.astral.sh/ruff/rules/#flake8-implicit-str-concat-isc
What
Close