Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

infra: format with ruff#2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JacobCoffee wants to merge2 commits intomain
base:main
Choose a base branch
Loading
from2539-formatting
Open

infra: format with ruff#2540

JacobCoffee wants to merge2 commits intomainfrom2539-formatting

Conversation

JacobCoffee
Copy link
Member

What

  • format with ruff

Close

@JacobCoffee
Copy link
MemberAuthor

JacobCoffee commentedSep 12, 2024
edited
Loading

there's about 7000 issues found with ruff lint. taking away docstring and missing type annotations its not so bad at around ~500 so working through some of those to see if its something we want to do (i do 🥹)

@ewdurbin
Copy link
Member

ewdurbin commentedSep 12, 2024
edited
Loading

Zero opposition, but please can handle all concerns then rebase this down to one commit so we can do something likehttps://black.readthedocs.io/en/stable/guides/introducing_black_to_your_project.html#avoiding-ruining-git-blame

JacobCoffee reacted with thumbs up emoji

"We're happy to announce the new way to file a contributor "
"agreement: on the web at",
self.entries[0]['summary']
"We're happy to announce the new way to file a contributor " "agreement: on the web at",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Turn on ISC to catch these:

Suggested change
"We're happy to announce the new way to file a contributor""agreement: on the web at",
"We're happy to announce the new way to file a contributor agreement: on the web at",

https://docs.astral.sh/ruff/rules/#flake8-implicit-str-concat-isc

JacobCoffee reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

infra(dev): add code formatting/linting
3 participants
@JacobCoffee@ewdurbin@hugovk

[8]ページ先頭

©2009-2025 Movatter.jp