Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

translate library/re.po Regular Expression Syntax#1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mattwang44 merged 2 commits intopython:3.14fromascodeasice:library/re
Nov 7, 2025

Conversation

@ascodeasice
Copy link
Contributor

#631

pre-commit 的 powrap 有動到一些我沒有翻譯的文字，如果需要將它們改回原本的樣子，我也可以修改

mattwang44 reacted with heart emoji
@mattwang44
Copy link
Collaborator

mattwang44 commentedSep 16, 2025•
edited
Loading

@ascodeasice

  • 沒關係先不用改，不知為何今年初開始原文 merge 進來和 powrap (pre-commit hook) 的 formatting 方式不同所以都會改動到，我還沒找到原因，但這不影響 build
  • 有 conflict 要請你先修掉歐
  • btw conflict 修完後如果 CI 還是失敗的話會是已知問題（我太早把 github action 的 python 升到 3.14 但 ubuntu 22 image 上還沒有 python 3.14，要再等我修一下）
ascodeasice reacted with thumbs up emoji

@mattwang44mattwang44 self-requested a reviewSeptember 16, 2025 11:33
Copy link
Collaborator

@mattwang44mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

review the first half

Copy link
Collaborator

@mattwang44mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

review part 2

@mattwang44
Copy link
Collaborator

btw conflict 修完後如果 CI 還是失敗的話會是已知問題（我太早把 github action 的 python 升到 3.14 但 ubuntu 22 image 上還沒有 python 3.14，要再等我修一下）

這個我修掉了，可以再 rebase 到最新的 3.14 上

@mattwang44
Copy link
Collaborator

Hi@ascodeasice,
想請問你會繼續修這隻 PR 嗎？還是我可以接手改動呢？

@ascodeasice
Copy link
ContributorAuthor

@mattwang44
非常不好意思，還是麻煩你進行改動好了，感謝

mattwang44 reacted with thumbs up emojimattwang44 reacted with heart emoji

@mattwang44mattwang44 self-assigned thisNov 7, 2025
@mattwang44mattwang44 marked this pull request as ready for reviewNovember 7, 2025 13:26
@mattwang44mattwang44 merged commit2adc9e1 intopython:3.14Nov 7, 2025
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mattwang44mattwang44mattwang44 left review comments

Assignees

@mattwang44mattwang44

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ascodeasice@mattwang44
[8]ページ先頭
©2009-2025 Movatter.jp